Opened 4 years ago

Closed 4 years ago

#26045 closed enhancement (fixed)

py3 some fixes in root_systems

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.4
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 4a2c244 (Commits, GitHub, GitLab) Commit: 4a2c24404774b1bff340fbf85843b902a3a060d1
Dependencies: Stopgaps:

Status badges

Description


Change History (11)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/26045
  • Commit set to 19f82d12c5f522f4f9b0ad05a30c492ffaaac2a2
  • Status changed from new to needs_review

New commits:

19f82d1various fixes for py3 in combinat and root_systems

comment:2 Changed 4 years ago by git

  • Commit changed from 19f82d12c5f522f4f9b0ad05a30c492ffaaac2a2 to 7456780bfb55ddedbe65b6bc4f31f724c00e7cb8

Branch pushed to git repo; I updated commit sha1. New commits:

7456780pyflakes cleanup in one file

comment:3 Changed 4 years ago by chapoton

  • Cc tscrim added

green bots

comment:4 Changed 4 years ago by tscrim

Overindented:

    TESTS::

            sage: Lambda[1]
            e[0] + e['deltacheck']

Also, sorting in the ambient space by str will lead to strange results for rank 11 and higher; e.g., e[0] + e[1] + e[10] + e[2] from

sage: sorted([0,10,1,2], key=str)
[0, 1, 10, 2]

A better solution IMO would be one of the following:

key=lambda x: float('inf') if isinstance(x, str) else x
key=lambda x: -1 if isinstance(x, str) else x

comment:5 Changed 4 years ago by git

  • Commit changed from 7456780bfb55ddedbe65b6bc4f31f724c00e7cb8 to 3c25ec35eeca78c629996eda6bae24dc201d72b3

Branch pushed to git repo; I updated commit sha1. New commits:

3c25ec3fix sorting key for affine root systems

comment:6 Changed 4 years ago by chapoton

Indeed. I have made a better sortkey.

comment:7 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thanks. LGTM.

comment:8 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:9 Changed 4 years ago by git

  • Commit changed from 3c25ec35eeca78c629996eda6bae24dc201d72b3 to 4a2c24404774b1bff340fbf85843b902a3a060d1

Branch pushed to git repo; I updated commit sha1. New commits:

4a2c244Merge branch 'u/chapoton/26045' in 8.4.b1

comment:10 Changed 4 years ago by chapoton

  • Status changed from needs_work to positive_review

setting back to positive after trivial rebase

comment:11 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/26045 to 4a2c24404774b1bff340fbf85843b902a3a060d1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.