Opened 20 months ago

Closed 20 months ago

#26043 closed defect (fixed)

py3: fix MethodType(meth, obj, cls)

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.4
Component: python3 Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ff5b7cc (Commits) Commit: ff5b7ccbaf5ae79b27d856d9862d056fe07e6aad
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The 3-argument constructor of MethodType no longer exists in Python 3.

Change History (6)

comment:1 Changed 20 months ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 20 months ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/26043

comment:3 Changed 20 months ago by jdemeyer

  • Commit set to 185abdc3d56a8620ed4ecd0112479ecd9cd54fe0
  • Status changed from new to needs_review

New commits:

​3b381f1trac 26037: fix typo in geometry/polyhedron/backend_ppl.py
​3abd3a2Check that the doctest is a valid single statement
​d6f50b9Fix %%cython doctest
​185abdcStop using 3-argument version of MethodType()

comment:4 Changed 20 months ago by git

  • Commit changed from 185abdc3d56a8620ed4ecd0112479ecd9cd54fe0 to ff5b7ccbaf5ae79b27d856d9862d056fe07e6aad

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​ff5b7ccStop using 3-argument version of MethodType()

comment:5 Changed 20 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 20 months ago by vbraun

  • Branch changed from u/jdemeyer/ticket/26043 to ff5b7ccbaf5ae79b27d856d9862d056fe07e6aad
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.