Changes between Initial Version and Version 1 of Ticket #26018, comment 18


Ignore:
Timestamp:
09/24/18 14:47:33 (4 years ago)
Author:
embray
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #26018, comment 18

    initial v1  
    1111I think that would have been completely fair, though I have mixed feelings about "before marking this as needs_review".  What I find insulting is the assumption that I (or anyone, if it were someone else) just didn't test it at all.  It might be a little more reasonable if were something that ''obviously'' would never have worked at all under ''any'' circumstances, like having a syntax error in some code such that it would not have even compiled.
    1212
    13 Even then there are cases I've seen, both from myself and others, where I had something working fine, but accidentally hit a key in my editor and inserted a stray symbol somewhere just before committing the change.  I almost always review my diff before committing, but something like that can be easy to fix (and of course if I did skip diff review entirely, that's on me).
     13Even then there are cases I've seen, both from myself and others, where I had something working fine, but accidentally hit a key in my editor and inserted a stray symbol somewhere just before committing the change.  I almost always review my diff before committing, but something like that can be easy to fix (and of course if I did skip diff review entirely, that's on me).  In fact, as I pointed out, this was in some ways such a case, since I had it "right" in the first place but then made a mistake before committing.  I did do a diff review but it was the sort that was easy to glaze over since it was dozens of almost equivalent changes.
    1414
    1515But I don't think anyone should be lectured to about setting a ticket to "needs review" if there happens to be a mistake.  That's the whole point of asking for review--it's saying "I've done everything I can ''or have time for'' to work on this; please take a look".