Changes between Initial Version and Version 1 of Ticket #26018, comment 13


Ignore:
Timestamp:
09/21/18 13:24:47 (4 years ago)
Author:
embray
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #26018, comment 13

    initial v1  
    44With respect, this is extremely condescending and unnecessary.  I'm a professional software engineer and you are not my employer or my mentor--you don't have to tell me how to do my job.  Obviously I tested it, being that it's a fairly non-trivial change.  I see what the problem is about pip and I'm not sure why I didn't hit on it, though I only would have if I were fully rebuilding from scratch (I believe, instead, I was doing some `./sage -f` calls that were designed to trigger the race condition).
    55
    6 Sage-the-distribution is a very large, complex pile of software, and it's difficult to test all possible scenarios, especially for builds.  I'm not sure what you think the point of "needs review" is, if not to provide peer-review, which includes peer-testing.  If you feel your time has been wasted you were also welcome to check the current results of the patchbots (which also show a build failure) and point that out rather than browbeating me needlessly.
     6Sage-the-distribution is a very large, complex pile of software, and it's difficult to test all possible scenarios, especially for builds.  I'm not sure what you think the point of "needs review" is, if not to provide peer-review, which includes peer-testing.  If you feel your time has been wasted you were also welcome to check the current results of the patchbots (which also show a build failure) and point that out rather than lecturing me needlessly.