Opened 4 months ago

Closed 4 months ago

#26012 closed defect (fixed)

Fix bug concerning restrictions of tensorfields

Reported by: gh-FlorentinJ Owned by:
Priority: major Milestone: sage-8.4
Component: geometry Keywords: restriction, extension, tensorfield, manifold
Cc: egourgoulhon Merged in:
Authors: Florentin Jaffredo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 043f084 (Commits) Commit: 043f08436dd36cd853d47a3855a260afd19420b5
Dependencies: Stopgaps:

Description

The attributes _restrictions_graph and _extensions_graph, introduced in #25417 were not affected by the method _del_derived, whereas _restrictions was, causing some issues.

Change History (5)

comment:1 Changed 4 months ago by gh-FlorentinJ

  • Status changed from new to needs_review

comment:2 Changed 4 months ago by tscrim

Do you have an explicit example where something was going wrong? If so, could you add it as a test to some TESTS:: block with a message saying something like ``_restrictions_graph`` and ``_extensions_graph`` was not changed (see :trac:`26012`)::

comment:3 Changed 4 months ago by git

  • Commit changed from e5787adef1d5c47f63190f4c478b0414cae7c389 to 043f08436dd36cd853d47a3855a260afd19420b5

Branch pushed to git repo; I updated commit sha1. New commits:

043f084Added TESTS:: block, typo

comment:4 Changed 4 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thanks. LGTM.

comment:5 Changed 4 months ago by vbraun

  • Branch changed from public/manifolds/better_restrictions_bugfix to 043f08436dd36cd853d47a3855a260afd19420b5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.