Opened 2 years ago

Closed 2 years ago

#25974 closed defect (fixed)

py3: fix unnecessary map() in sage.calculus.riemann

Reported by: embray Owned by:
Priority: major Milestone: sage-8.4
Component: python3 Keywords:
Cc: egourgoulhon Merged in:
Authors: Erik Bray Reviewers: Kevin Dilks
Report Upstream: N/A Work issues:
Branch: 6b7e132 (Commits) Commit: 6b7e132b26f4d78d18fd338f880cd1d9cde973b4
Dependencies: Stopgaps:

Description

This one silly fix took this module from 67 doctests failing to 100% passing on my python3 branch.

Change History (7)

comment:1 Changed 2 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 2 years ago by kdilks

  • Status changed from needs_review to needs_work

Patchbot shows a lot of elliptic function methods and other things that may be related failing.

comment:3 Changed 2 years ago by embray

That's quite a coincidence but I don't think it's related. I believe those failures are due to a bug in uninstalling/reinstalling the sympow package. I encountered the same recently myself. I will run the tests locally just to be sure though.

comment:4 Changed 2 years ago by embray

  • Status changed from needs_work to needs_review

Yeah, I was able to confirm that these tests pass locally, but breaking the sympow executable breaks them. This is due to #25856, but not this ticket.

comment:5 Changed 2 years ago by kdilks

  • Reviewers set to Kevin Dilks
  • Status changed from needs_review to positive_review

I also just ran the tests on my machine with no problems.

comment:6 Changed 2 years ago by tscrim

  • Cc egourgoulhon added

comment:7 Changed 2 years ago by vbraun

  • Branch changed from u/embray/python3/sage-calculus-riemann/map to 6b7e132b26f4d78d18fd338f880cd1d9cde973b4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.