Opened 4 years ago

Closed 4 years ago

#25945 closed defect (fixed)

py3: miscellaneous str/bytes fixes in sage.rings

Reported by: embray Owned by:
Priority: minor Milestone: sage-8.4
Component: python3 Keywords: sagedays@icerm
Cc: Merged in:
Authors: Erik Bray Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c36c172 (Commits, GitHub, GitLab) Commit: c36c172c76f867ce1794dd4318c53bbc1c4e4ab0
Dependencies: Stopgaps:

Status badges

Description


Change History (8)

comment:1 Changed 4 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

You can set to a positive review if a patchbot comes back (morally) green.

comment:3 Changed 4 years ago by tscrim

  • Keywords sagedays@icerm added

comment:4 Changed 4 years ago by chapoton

  • Status changed from needs_review to positive_review

This seems to be the case..

comment:5 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:6 Changed 4 years ago by chapoton

  • Branch changed from u/embray/python3/sage-rings/misc-str-bytes to public/25945
  • Commit changed from 77b4b0c000f5f2a24fa098cc58077f9a3f6a0ec7 to c36c172c76f867ce1794dd4318c53bbc1c4e4ab0
  • Status changed from needs_work to positive_review

trivial rebase, set back to positive

New commits:

​c36c172Merge branch 'u/embray/python3/sage-rings/misc-str-bytes' in 8.4.b2

comment:7 Changed 4 years ago by embray

It's not a rebase if you do a merge but whatever, thank you.

comment:8 Changed 4 years ago by vbraun

  • Branch changed from public/25945 to c36c172c76f867ce1794dd4318c53bbc1c4e4ab0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.