Opened 12 months ago
Closed 12 months ago
#25908 closed task (fixed)
Printing of padic extensions
Reported by:  caruso  Owned by:  

Priority:  major  Milestone:  sage8.4 
Component:  padics  Keywords:  printing, padicIMA 
Cc:  roed, slelievre  Merged in:  
Authors:  Xavier Caruso  Reviewers:  David Roe 
Report Upstream:  N/A  Work issues:  
Branch:  648ea64 (Commits)  Commit:  648ea644958f6d52d2a6d2d9a55bb8412f4dd95b 
Dependencies:  Stopgaps: 
Description (last modified by )
We make the print representation of padic extensions shorter and clearer (in order to prepare #23218).
For example, the different outputs below from before this ticket:
sage: R.<a> = ZqCR(25, 40); R Unramified Extension in a defined by x^2 + 4*x + 2 with capped relative precision 40 over 5adic Ring sage: R.<a> = ZqCA(25, 40); R Unramified Extension in a defined by x^2 + 4*x + 2 with capped absolute precision 40 over 5adic Ring sage: R.<a> = ZqFM(25, 40); R Unramified Extension in a defined by x^2 + 4*x + 2 of fixed modulus 5^40 over 5adic Ring sage: R.<a> = ZqFP(25, 40); R Unramified Extension in a defined by x^2 + 4*x + 2 with floating precision 40 over 5adic Ring
become the same shorter outpout after this ticket:
sage: R.<a> = ZqCR(25, 40); R 5adic Unramified Extension Ring in a defined by x^2 + 4*x + 2 sage: R.<a> = ZqCA(25, 40); R 5adic Unramified Extension Ring in a defined by x^2 + 4*x + 2 sage: R.<a> = ZqFM(25, 40); R 5adic Unramified Extension Ring in a defined by x^2 + 4*x + 2 sage: R.<a> = ZqFP(25, 40); R 5adic Unramified Extension Ring in a defined by x^2 + 4*x + 2
Change History (21)
comment:1 Changed 12 months ago by
 Branch set to u/roed/padic_printing
comment:2 Changed 12 months ago by
 Commit set to debf1fc2d9240d7a9a5cec8d66f269102b219f6c
 Keywords padicIMA added
comment:3 Changed 12 months ago by
 Branch changed from u/roed/padic_printing to u/caruso/padic_parent_printing
comment:4 Changed 12 months ago by
 Commit changed from debf1fc2d9240d7a9a5cec8d66f269102b219f6c to 25c86a6977e8456fe7c35cbdf4e5927952e37460
Branch pushed to git repo; I updated commit sha1. New commits:
25c86a6  Change printing for padic extensions

comment:5 Changed 12 months ago by
 Commit changed from 25c86a6977e8456fe7c35cbdf4e5927952e37460 to e74fe636d1244fc6540515f039dbf65c26115c21
Branch pushed to git repo; I updated commit sha1. New commits:
e74fe63  Doctest for the helper method _extension_type

comment:6 Changed 12 months ago by
I get these failures:
sage t src/sage/categories/pushout.py # 1 doctest failed sage t src/sage/modular/overconvergent/genus0.py # 4 doctests failed sage t src/sage/rings/padics/CA_template.pxi # 6 doctests failed sage t src/sage/rings/padics/CR_template.pxi # 6 doctests failed sage t src/sage/rings/padics/FM_template.pxi # 6 doctests failed sage t src/sage/rings/padics/FP_template.pxi # 6 doctests failed sage t src/sage/rings/polynomial/padics/polynomial_padic.py # 2 doctests failed sage t src/sage/rings/polynomial/polynomial_element.pyx # 1 doctest failed sage t src/sage/rings/finite_rings/finite_field_base.pyx # 2 doctests failed sage t src/sage/rings/ring.pyx # 1 doctest failed sage t src/sage/schemes/hyperelliptic_curves/hyperelliptic_generic.py # 1 doctest failed sage t src/sage/schemes/elliptic_curves/padic_lseries.py # 1 doctest failed sage t src/sage/schemes/hyperelliptic_curves/hyperelliptic_padic_field.py # 1 doctest failed sage t src/sage/structure/parent.pyx # 1 doctest failed
comment:7 Changed 12 months ago by
 Commit changed from e74fe636d1244fc6540515f039dbf65c26115c21 to 5c4e3a35ac7d0570b09b4b58c5c419657bfb688b
Branch pushed to git repo; I updated commit sha1. New commits:
5c4e3a3  Fix doctest

comment:8 Changed 12 months ago by
 Description modified (diff)
 Status changed from new to needs_review
I've fixed the doctests. The ticket is ready for review.
comment:9 Changed 12 months ago by
 Commit changed from 5c4e3a35ac7d0570b09b4b58c5c419657bfb688b to 7c5c68cd14782ffef200e101638c37476858527d
Branch pushed to git repo; I updated commit sha1. New commits:
7c5c68c  Notion of absolute and relative degree / ramification index / inertia degree

comment:10 Changed 12 months ago by
 Commit changed from 7c5c68cd14782ffef200e101638c37476858527d to c722955275b9e19b262440e4eedce2f5060ed755
Branch pushed to git repo; I updated commit sha1. New commits:
c722955  Added/fixed doctests

comment:11 Changed 12 months ago by
 Branch changed from u/caruso/padic_parent_printing to u/roed/padic_parent_printing
comment:12 Changed 12 months ago by
 Branch changed from u/roed/padic_parent_printing to u/caruso/padic_parent_printing
 Reviewers set to David Roe
 Status changed from needs_review to positive_review
comment:13 Changed 12 months ago by
 Branch changed from u/caruso/padic_parent_printing to u/roed/padic_parent_printing
 Commit changed from c722955275b9e19b262440e4eedce2f5060ed755 to 8815d83e8cddeb5854b2181615fa671f36ca1a0d
New commits:
8815d83  Fix typos

comment:14 Changed 12 months ago by
 Cc slelievre added
 Description modified (diff)
comment:15 Changed 12 months ago by
 Status changed from positive_review to needs_work
Patchbot (on cygwin) complains. Let's try again.
comment:16 Changed 12 months ago by
 Status changed from needs_work to needs_review
comment:17 Changed 12 months ago by
 Branch changed from u/roed/padic_parent_printing to u/caruso/padic_parent_printing
comment:18 Changed 12 months ago by
 Commit changed from 8815d83e8cddeb5854b2181615fa671f36ca1a0d to 648ea644958f6d52d2a6d2d9a55bb8412f4dd95b
All tests pass for me. We can wait for the patchbot to see if there are plugin errors.
New commits:
648ea64  "base field" / "base ring"

comment:19 Changed 12 months ago by
If you agree, I give a positive review and open a new ticket for the pyflakes issues found by the patchbot.
comment:20 Changed 12 months ago by
 Status changed from needs_review to positive_review
comment:21 Changed 12 months ago by
 Branch changed from u/caruso/padic_parent_printing to 648ea644958f6d52d2a6d2d9a55bb8412f4dd95b
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Commit to make different from develop