Changes between Version 7 and Version 8 of Ticket #25896


Ignore:
Timestamp:
07/22/18 09:44:48 (4 years ago)
Author:
jdemeyer
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25896 – Description

    v7 v8  
    44443. The code assumes implicitly that the generator of a finite field is a multiplicative generator (this is easy to fix).
    4545
    46 4. It becomes very inefficient as `n` gets moderately large.
    47 
    48 5. Since you explicitly refer to the docstring of `_is_a_splitting`, the latter should be public and documented.
     464. Since you explicitly refer to the docstring of `_is_a_splitting`, the latter should be public and documented.
    4947
    5048I can imagine that 1. and 2. should be considered "bad input" but that's not clear. It seems that there is an additional hidden assumption that `q S1 = S1` (and then also `q S2 = S2`).