Changes between Version 6 and Version 7 of Ticket #25896


Ignore:
Timestamp:
07/22/18 08:14:52 (4 years ago)
Author:
jdemeyer
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25896 – Description

    v6 v7  
    48485. Since you explicitly refer to the docstring of `_is_a_splitting`, the latter should be public and documented.
    4949
    50 I can imagine that 1. and 2. should be considered "bad input" but in that case the documentation must be updated. That's the absolute minimum that must be done before anything else: if we don't even know what the function ''should'' do, we cannot fix it.
     50I can imagine that 1. and 2. should be considered "bad input" but that's not clear. It seems that there is an additional hidden assumption that `q S1 = S1` (and then also `q S2 = S2`).
     51
     52Updating the documentation is the absolute minimum that must be done before anything else: if we don't even know what the function ''should'' do, we cannot fix it.