#25880 closed enhancement (fixed)

cleanup of free Zinbiel algebras

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.4
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b2d12bc (Commits) Commit: b2d12bc50641565db92eab43ebad5b2c87d1e415
Dependencies: Stopgaps:

Description

full pep8, pyflakes and coverage

Change History (6)

comment:1 Changed 23 months ago by chapoton

  • Branch set to u/chapoton/25880
  • Cc tscrim added
  • Commit set to e8705b658e5331818f962868c5ac8358ac34a0b3
  • Status changed from new to needs_review

New commits:

e8705b6fixing details in zinbiel algebras : full pep8, pyflakes and coverage

comment:2 Changed 23 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

A while-we-are-at-it: can you change the header to use the standard copyright?

Bikeshedding: I find it better to break the 80 char/line guideline for code to avoid small breaks like this:

-        return super(FreeZinbielAlgebra, cls).__classcall__(cls, R, n, tuple(names))
+        return super(FreeZinbielAlgebra, cls).__classcall__(cls, R, n,
+                                                            tuple(names))

Bikeshedding nitpick:

-        - ``x`` and ``y`` -- two words
+        - ``x``, ``y`` -- two words

If you disagree with my comments, then I will be happy to set this to a positive review.

comment:3 Changed 23 months ago by git

  • Commit changed from e8705b658e5331818f962868c5ac8358ac34a0b3 to b2d12bc50641565db92eab43ebad5b2c87d1e415

Branch pushed to git repo; I updated commit sha1. New commits:

b2d12bcsome suggested details

comment:4 Changed 23 months ago by chapoton

Thanks for the review, Travis. All done, I hope.

comment:5 Changed 23 months ago by tscrim

  • Status changed from needs_review to positive_review

Thank you. LGTM.

comment:6 Changed 22 months ago by vbraun

  • Branch changed from u/chapoton/25880 to b2d12bc50641565db92eab43ebad5b2c87d1e415
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.