Opened 3 years ago

Closed 3 years ago

#25877 closed defect (fixed)

dehomogenize for projective morphism failure in number field order

Reported by: bhutz Owned by:
Priority: minor Milestone: sage-8.4
Component: algebraic geometry Keywords:
Cc: Merged in:
Authors: Ben Hutz Reviewers: Raghukul Raman
Report Upstream: N/A Work issues:
Branch: 45a4ae7 (Commits, GitHub, GitLab) Commit: 45a4ae77ffc0b85a800395425c542cd8e5d354b0
Dependencies: Stopgaps:

Status badges

Description

When the 'denominator' is a constant dehomogenization fails 

K.<w>=QuadraticField(3)
O=K.ring_of_integers()
P.<x,y>=ProjectiveSpace(O,1)
H=End(P)
f=H([x^2 - O(w)*y^2,y^2])
f.dehomogenize(1)

Change History (3)

comment:1 Changed 3 years ago by bhutz

  • Authors set to Ben Hutz
  • Branch set to u/bhutz/25877_dehomogenize
  • Commit set to 45a4ae77ffc0b85a800395425c542cd8e5d354b0
  • Status changed from new to needs_review

Fixed.

Interestingly it caused a doc test failure in projective_ds.py. Extending the precision, it looks like the new value is actually the correct one so I updated the test.

New commits:

​45a4ae725877: fix dehomogenize for projective morphism

comment:2 Changed 3 years ago by raghukul01

  • Reviewers set to Raghukul Raman
  • Status changed from needs_review to positive_review
  • Summary changed from dehomogenize for projecgive morphism failure in number field order to dehomogenize for projective morphism failure in number field order

comment:3 Changed 3 years ago by vbraun

  • Branch changed from u/bhutz/25877_dehomogenize to 45a4ae77ffc0b85a800395425c542cd8e5d354b0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.