Opened 3 years ago
Closed 3 years ago
#25865 closed enhancement (fixed)
fast iterator for set partitions with given block sizes
Reported by:  mantepse  Owned by:  

Priority:  major  Milestone:  sage8.7 
Component:  combinatorics  Keywords:  
Cc:  tscrim, kdilks  Merged in:  
Authors:  Martin Rubey  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  027b299 (Commits, GitHub, GitLab)  Commit:  027b299fbf870eca6918badfe23059fc58e0abbe 
Dependencies:  #25462, #25864  Stopgaps: 
Description (last modified by )
As promised in https://trac.sagemath.org/ticket/25462#comment:56, this provides a fast iterator for set partitions with given block sizes, via linear extensions of a certain poset.
Change History (15)
comment:1 Changed 3 years ago by
 Branch set to u/mantepse/fast_iterator_for_set_partitions_with_given_block_sizes
comment:2 Changed 3 years ago by
 Cc tscrim added
 Commit set to 84ba2c82cafbb78bb6107175bfa3fbdc1d1927bc
 Component changed from PLEASE CHANGE to combinatorics
 Dependencies set to #25462, #25864
 Description modified (diff)
 Type changed from PLEASE CHANGE to enhancement
comment:3 Changed 3 years ago by
 Commit changed from 84ba2c82cafbb78bb6107175bfa3fbdc1d1927bc to 78bb5c89e61cc127ac10beac0400cf0fba9c66ea
Branch pushed to git repo; I updated commit sha1. New commits:
8050b00  create graphs.LinearExtensions.__iter__, adapt a few methods and doctests

f1705d8  fix mistake in initialisation of LinearExtensions and adapt doctests

0765e7f  Merge branch 'u/mantepse/make_linearextensions_an_iterator' of git://trac.sagemath.org/sage into t/25865/fast_iterator_for_set_partitions_with_given_block_sizes

78bb5c8  fix typo

comment:4 Changed 3 years ago by
 Status changed from new to needs_review
comment:5 Changed 3 years ago by
 Cc kdilks added
comment:6 Changed 3 years ago by
 Commit changed from 78bb5c89e61cc127ac10beac0400cf0fba9c66ea to 9278b8eeeba80d8a1ecc553963fb29b7171393ae
Branch pushed to git repo; I updated commit sha1. New commits:
9278b8e  Merge branch 'develop' of git://trac.sagemath.org/sage into t/25865/fast_iterator_for_set_partitions_with_given_block_sizes

comment:7 Changed 3 years ago by
 Commit changed from 9278b8eeeba80d8a1ecc553963fb29b7171393ae to 746113ae3e34f68d3231f781882162eee9abf148
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
f9a7227  fix pyflakes import statements

84aad72  deprecate LinearExtensions

d8795fb  do not sort in methods

dcb8fe3  Merge branch 'develop' of git://trac.sagemath.org/sage into t/25864/make_linearextensions_an_iterator

8512ff7  Merge branch 'develop' of git://trac.sagemath.org/sage into t/25864/make_linearextensions_an_iterator

9ec826f  fix doctests

4ec1900  remove sorting in doctests by reviewer's request

cca1616  Merge branch 'develop' of git://trac.sagemath.org/sage into t/25864/make_linearextensions_an_iterator

42dad7d  Merge branch 't/25864/make_linearextensions_an_iterator' into t/25865/fast_iterator_for_set_partitions_with_given_block_sizes

746113a  make iter work with arbitrary base sets, adapt doctests, remove old iterator, deprecate property

comment:8 Changed 3 years ago by
 Commit changed from 746113ae3e34f68d3231f781882162eee9abf148 to add1d3f58053cbf311211c61150c9cf21a39f30e
Branch pushed to git repo; I updated commit sha1. New commits:
add1d3f  make iterator much faster, adapt doctests

comment:9 Changed 3 years ago by
 Commit changed from add1d3f58053cbf311211c61150c9cf21a39f30e to 027b299fbf870eca6918badfe23059fc58e0abbe
Branch pushed to git repo; I updated commit sha1. New commits:
027b299  remove unused imports, fix remaining doctests

comment:10 Changed 3 years ago by
 Milestone changed from sage8.4 to sage8.6
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
LGTM.
comment:11 Changed 3 years ago by
Thank you!
comment:12 followup: ↓ 13 Changed 3 years ago by
Did anyone check for conflicts with #26917?
comment:13 in reply to: ↑ 12 Changed 3 years ago by
comment:14 Changed 3 years ago by
 Milestone changed from sage8.6 to sage8.7
Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sagepending or sagewishlist.
comment:15 Changed 3 years ago by
 Branch changed from u/mantepse/fast_iterator_for_set_partitions_with_given_block_sizes to 027b299fbf870eca6918badfe23059fc58e0abbe
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
avoid itertools and modify docstring
Merge commit 'ca293e3' into public/25462
make doctests more independent of ordering
Merge commit '9c5298d' into public/25462
restore richer doc tests
reviewer's comments
provide iterators which return lists of lists
inline a computation by reviewer's request
Merge branch 'public/25462' of git://trac.sagemath.org/sage into t/25865/fast_iterator_for_set_partitions_with_given_block_sizes
a faster iterator for set partitions with given block sizes