Opened 3 years ago

Closed 3 years ago

#25847 closed enhancement (fixed)

LatticePoset: Optimize is_simple()

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-8.4
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f314a96 (Commits, GitHub, GitLab) Commit: f314a965ff584a0e1ea19af342fa4d0190a2ccd4
Dependencies: Stopgaps:

Status badges

Description

Very minor heuristic.

After P = posets.BooleanLattice(8) compare timings of P.congruence([[0, 1]]) and P.congruence([[0, 128]]) to understand the reason.

Change History (5)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/is_simple-bug

comment:2 Changed 3 years ago by jmantysalo

  • Commit set to f314a965ff584a0e1ea19af342fa4d0190a2ccd4
  • Status changed from new to needs_review

New commits:

f314a96Add sort before computing congruences.

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 3 years ago by jmantysalo

Pathcbot failures, but they all seems to be marked with # optional - magma so I suppose they are not really because of this ticket.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/is_simple-bug to f314a965ff584a0e1ea19af342fa4d0190a2ccd4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.