Opened 4 years ago

Closed 4 years ago

#25847 closed enhancement (fixed)

LatticePoset: Optimize is_simple()

Reported by: Jori Mäntysalo Owned by:
Priority: minor Milestone: sage-8.4
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f314a96 (Commits, GitHub, GitLab) Commit: f314a965ff584a0e1ea19af342fa4d0190a2ccd4
Dependencies: Stopgaps:

Status badges

Description

Very minor heuristic.

After P = posets.BooleanLattice(8) compare timings of P.congruence([[0, 1]]) and P.congruence([[0, 128]]) to understand the reason.

Change History (5)

comment:1 Changed 4 years ago by Jori Mäntysalo

Branch: u/jmantysalo/is_simple-bug

comment:2 Changed 4 years ago by Jori Mäntysalo

Commit: f314a965ff584a0e1ea19af342fa4d0190a2ccd4
Status: newneeds_review

New commits:

f314a96Add sort before computing congruences.

comment:3 Changed 4 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:4 Changed 4 years ago by Jori Mäntysalo

Pathcbot failures, but they all seems to be marked with # optional - magma so I suppose they are not really because of this ticket.

comment:5 Changed 4 years ago by Volker Braun

Branch: u/jmantysalo/is_simple-bugf314a965ff584a0e1ea19af342fa4d0190a2ccd4
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.