Opened 4 years ago

Closed 4 years ago

#25846 closed enhancement (fixed)

Allow with_bounds to work on non-facade posets

Reported by: deinst Owned by:
Priority: minor Milestone: sage-8.4
Component: combinatorics Keywords:
Cc: Merged in:
Authors: David Einstein Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3658311 (Commits, GitHub, GitLab) Commit: 3658311d57edeb4aaae20ca051520d85d610e13e
Dependencies: Stopgaps:

Status badges


Currently with_bounds is not implemented on non-facade posets. This may or not be a good idea, as often one would want the elements in the old poset and the poset with bounds to be comparable, and therefore having facade=True, but the current behavior is surprising.

We should either document that with_bounds does not work with non-facade posets, or create an implementation

Change History (7)

comment:1 Changed 4 years ago by deinst

  • Branch set to u/deinst/fix_poset_with_bounds

comment:2 Changed 4 years ago by deinst

  • Commit set to d061ea05a9de9245e8e99271165bf33bf1ee8ec9
  • Status changed from new to needs_review

New commits:

d061ea0Allow with_bounds to work on non-facade posets

comment:3 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Trivial PEP8 thing:

-P = posets.PentagonPoset(facade = False)
+P = posets.PentagonPoset(facade=False)

Once changed, you can set a positive review on my behalf.

comment:4 Changed 4 years ago by git

  • Commit changed from d061ea05a9de9245e8e99271165bf33bf1ee8ec9 to 3658311d57edeb4aaae20ca051520d85d610e13e

Branch pushed to git repo; I updated commit sha1. New commits:

3658311Fixed extra spaces in named parameter.

comment:5 Changed 4 years ago by deinst

  • Status changed from needs_review to positive_review

Sorry, Thanks.

comment:6 Changed 4 years ago by chapoton

  • Authors changed from David EInstein to David Einstein

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/deinst/fix_poset_with_bounds to 3658311d57edeb4aaae20ca051520d85d610e13e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.