Opened 3 years ago

Closed 3 years ago

#25814 closed enhancement (fixed)

Upgrade to cysignals 1.7.2

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-8.3
Component: packages: standard Keywords: upgrade, cysignals
Cc: arojas, embray, fbissey, gh-timokau, infinity0, slelievre, thansen, tmonteil Merged in:
Authors: Jeroen Demeyer Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: a41caf4 (Commits, GitHub, GitLab) Commit: a41caf4adf015103499f96e6fa69a94bfb530b82
Dependencies: Stopgaps:

Status badges

Change History (13)

comment:1 Changed 3 years ago by gh-timokau

Already updated the nix package, it was a trivial update.

comment:2 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 3 years ago by slelievre

  • Cc arojas fbissey gh-timokau infinity0 slelievre thansen tmonteil added
  • Keywords upgrade cysignals added
  • Summary changed from Upgrade cysignals to Upgrade to cysignals 1.7.2

comment:4 Changed 3 years ago by embray

Then this just needs the necessary updates to build/pkgs/cysignals?

comment:5 Changed 3 years ago by embray

  • Branch set to u/embray/pkgs/cysignals/update-1.7.2
  • Commit set to a41caf4adf015103499f96e6fa69a94bfb530b82
  • Status changed from new to needs_review

New commits:

a41caf4Upgrade cysignals to 1.7.2

comment:6 Changed 3 years ago by embray

Confirmed that with this branch plus #25620 all ptestlong tests pass on Cygwin \o/

comment:7 Changed 3 years ago by jdemeyer

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

Thanks!

comment:8 Changed 3 years ago by embray

  • Priority changed from major to blocker

comment:9 Changed 3 years ago by vbraun

  • Priority changed from blocker to major

Doesn't fix a supported platform -> Not a blocker

comment:10 Changed 3 years ago by embray

  • Priority changed from major to blocker

Windows is a supported platform.

comment:11 Changed 3 years ago by vbraun

No buildbot => not a fully supported platform

comment:12 Changed 3 years ago by embray

  • Description modified (diff)

comment:13 Changed 3 years ago by vbraun

  • Branch changed from u/embray/pkgs/cysignals/update-1.7.2 to a41caf4adf015103499f96e6fa69a94bfb530b82
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.