Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#25806 closed defect (fixed)

Pass --no-readline to R

Reported by: Julian Rüth Owned by:
Priority: major Milestone: sage-8.4
Component: interfaces Keywords:
Cc: François Bissey, Antonio Rojas, Ximin Luo, Jeroen Demeyer, Erik Bray Merged in:
Authors: Ximin Luo, Julian Rüth Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: 9e6ea7e (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Julian Rüth)

Conda and Gentoo (and apparently also ArchLinux and Debian) suffer from hangs when talking to R through the pexpect interface on the first invocation in a Sage session. It is unclear what is the underlying issue. Shortening Sage's R prompt seems to fix the issue as does passing --no-readline to R.

Is there any reason why we should keep readline support when talking to R with the pexpect interface? Otherwise, we should just pass on that flag even though we do not fully understand why it fixes that particular issue.

See https://github.com/conda-forge/sagelib-feedstock/issues/19#issuecomment-402557595, and https://github.com/cschwan/sage-on-gentoo/blob/master/sci-mathematics/sage/files/dt-r-no-readline.patch.

Change History (10)

comment:1 Changed 4 years ago by Julian Rüth

Branch: u/saraedum/25806

comment:2 Changed 4 years ago by Julian Rüth

Commit: 2d8f4bc9e6acd82f386a92ad087580c9b9d1d1fe
Status: newneeds_review
Work issues: is the patchbot happy?

New commits:

2d8f4bcPass --no-readline to R otherwise Pexpect hangs

comment:3 Changed 4 years ago by Julian Rüth

Description: modified (diff)

comment:4 Changed 4 years ago by git

Commit: 2d8f4bc9e6acd82f386a92ad087580c9b9d1d1fe9e6ea7e3a2eb5c9d28159942b6d794a6e830a148

Branch pushed to git repo; I updated commit sha1. New commits:

9e6ea7eLink to #25806 to explain the --no-readline switch

comment:5 Changed 4 years ago by Erik Bray

Reviewers: Erik Bray
Status: needs_reviewpositive_review

This makes sense to me. There is a similar issue #25363 where it was needed to disable prompt_toolkit for Cantor's pexect interface to Sage to work (I believe Cantor is wrong to use pexpect to wrap Sage in the first place, but that's a different story).

I don't know why this would be a problem on some platforms but not others.


New commits:

9e6ea7eLink to #25806 to explain the --no-readline switch

comment:6 Changed 4 years ago by Julian Rüth

Status: positive_reviewneeds_review
Work issues: is the patchbot happy?is the patchbot happy ⇒ positive review

Great. Let's wait for the patchbot to actually pass as I have not run doctests for this myself.

comment:7 Changed 4 years ago by Thierry Monteil

#25503 does this already, and should ease downstream packaging (still needs review).

Replying to embray: [...]

I don't know why this would be a problem on some platforms but not others.

To what i understand, this is not a platform issue, but a version issue: our interface does not work with readline 7.

comment:8 Changed 4 years ago by Julian Rüth

Status: needs_reviewpositive_review
Work issues: is the patchbot happy ⇒ positive review

comment:9 Changed 4 years ago by Volker Braun

Branch: u/saraedum/258069e6ea7e3a2eb5c9d28159942b6d794a6e830a148
Resolution: fixed
Status: positive_reviewclosed

comment:10 Changed 4 years ago by Julian Rüth

Commit: 9e6ea7e3a2eb5c9d28159942b6d794a6e830a148
Milestone: sage-8.3sage-8.4

I might have misunderstood what the milestone stands for but I thought it would be the release of Sage that includes this. So, this is not in 8.3 yet but will only be in 8.4.

Note: See TracTickets for help on using tickets.