Opened 3 years ago

Closed 19 months ago

Last modified 19 months ago

#25797 closed enhancement (fixed)

Implement graftal lace cellular automata

Reported by: tscrim Owned by:
Priority: major Milestone: sage-9.1
Component: dynamics Keywords: cellular automata
Cc: chapoton Merged in:
Authors: Travis Scrimshaw Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: bded57c (Commits, GitHub, GitLab) Commit: bded57c97aaa2673005d36c168461503dd7b06c3
Dependencies: #25796 Stopgaps:

Status badges

Description

Following https://arxiv.org/abs/1805.11532, we implement graftal lace cellular automata (GLCA).

Change History (17)

comment:1 Changed 3 years ago by tscrim

  • Branch set to public/dynamics/glca-25797
  • Commit set to d3db5b64f80036051bb567562b67c830683ae95a
  • Status changed from new to needs_review

New commits:

3a9f81dInitial implementation of elementary cellular automata.
d3db5b6Initial implementation of GLCAs.

comment:2 Changed 3 years ago by git

  • Commit changed from d3db5b64f80036051bb567562b67c830683ae95a to 82946c1735f569342ecb2de7c0b08cf5741b1aff

Branch pushed to git repo; I updated commit sha1. New commits:

16a49a0Merge branch 'develop' into public/dynamics/glca-25797
82946c1Adding glca.py to references.

comment:3 Changed 3 years ago by tscrim

  • Cc chapoton added
  • Milestone changed from sage-8.3 to sage-8.4

This and #25796 are in the kinda-fun category of things to play with in Sage. If you have a few moments, I'd appreciate a review (but this is far from a priority, so feel free to ignore).

comment:4 Changed 20 months ago by chapoton

  • Milestone changed from sage-8.4 to sage-9.2
  • Status changed from needs_review to needs_work

now the branch is red.

How are things going ?

comment:5 Changed 19 months ago by git

  • Commit changed from 82946c1735f569342ecb2de7c0b08cf5741b1aff to 70947de0793bfaf4d2698a4fefadd439097b041f

Branch pushed to git repo; I updated commit sha1. New commits:

70947deMerge branch 'public/dynamics/glca-25797' of git://trac.sagemath.org/sage into public/dynamics/glca-25797

comment:6 follow-up: Changed 19 months ago by chapoton

Hello !

The raise "invalid rule" must be doctested.

comment:7 Changed 19 months ago by tscrim

Trivial rebase (just in the master reference file). I will add the doctests tomorrow when I get into my office.

I am doing okay. Australia is thinking of starting to relax restrictions in a few weeks. How are things for you?

comment:8 Changed 19 months ago by git

  • Commit changed from 70947de0793bfaf4d2698a4fefadd439097b041f to af577a714e4d63fac19a1093f611b75ef2de2bba

Branch pushed to git repo; I updated commit sha1. New commits:

af577a7Added tests for invalid rule.

comment:9 in reply to: ↑ 6 Changed 19 months ago by tscrim

Replying to chapoton:

The raise "invalid rule" must be doctested.

Done.

comment:10 Changed 19 months ago by tscrim

  • Status changed from needs_work to needs_review

comment:11 follow-up: Changed 19 months ago by chapoton

Here I'm doing ok too, sort of. Trying hard not to turn crazy.

Some more comments:

Pyflakes plugins is not happy.

Maybe use https://www.gnu.org/licenses/ in the header (with https)

What is the default behaviour of evolve : how many steps if number is None ?

Maybe the name András Kaszanyitzky should appear in the file itself ?

comment:12 Changed 19 months ago by git

  • Commit changed from af577a714e4d63fac19a1093f611b75ef2de2bba to bded57c97aaa2673005d36c168461503dd7b06c3

Branch pushed to git repo; I updated commit sha1. New commits:

bded57cSome additional touchups.

comment:13 in reply to: ↑ 11 Changed 19 months ago by tscrim

Replying to chapoton:

Pyflakes plugins is not happy.

Fixed.

Maybe use https://www.gnu.org/licenses/ in the header (with https)

Fixed, I think.

What is the default behaviour of evolve : how many steps if number is None ?

Fixed.

Maybe the name András Kaszanyitzky should appear in the file itself ?

I don't think this is necessary as there is a reference to the paper itself and I don't think there is a natural place to put it.

comment:14 Changed 19 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, agreed. Good to go.

comment:15 Changed 19 months ago by tscrim

Thank you.

comment:16 Changed 19 months ago by vbraun

  • Branch changed from public/dynamics/glca-25797 to bded57c97aaa2673005d36c168461503dd7b06c3
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:17 Changed 19 months ago by mkoeppe

  • Milestone changed from sage-9.2 to sage-9.1
Note: See TracTickets for help on using tickets.