Opened 3 years ago

Closed 3 years ago

#25777 closed enhancement (fixed)

adding partition keyword for plot3d of graphs

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.3
Component: graphics Keywords:
Cc: dcoudert Merged in:
Authors: Frédéric Chapoton Reviewers: David Coudert, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 5c380e7 (Commits, GitHub, GitLab) Commit: 5c380e7f7dcc4fc82db71adb41b3217624b32c9c
Dependencies: Stopgaps:

Status badges

Description


Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/25777
  • Commit set to 5c380e7f7dcc4fc82db71adb41b3217624b32c9c
  • Status changed from new to needs_review

New commits:

​5c380e7adding partition keyword for plot3d of graphs

comment:2 Changed 3 years ago by chapoton

  • Cc dcoudert added

comment:3 Changed 3 years ago by dcoudert

The code looks good, but I'm unfortunately unable to test it on my laptop (I'm blocked to 8.2.rc1 until I succeed to update my system). I tried to do X forwarding from a server but the jmol java stuff displays nothing while G.show() is working fine...

comment:4 Changed 3 years ago by tscrim

  • Reviewers set to David Coudert, Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/25777 to 5c380e7f7dcc4fc82db71adb41b3217624b32c9c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.