Opened 2 years ago
Closed 2 years ago
#25761 closed defect (fixed)
Matrices to elements of finite unitary groups are not unitary!
Reported by:  soehms  Owned by:  

Priority:  major  Milestone:  sage8.3 
Component:  linear algebra  Keywords:  days94, sagedays@icerm 
Cc:  tscrim  Merged in:  
Authors:  Sebastian Oehms  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  2cdff9f (Commits)  Commit:  2cdff9fdb4344fa0829a5486a309f8151bef25ea 
Dependencies:  Stopgaps: 
Description (last modified by )
Example:
sage: G32=GU(3,2) sage: g1, g2 =G32.gens() sage: g1.matrix().is_unitary() False
The consequence of this is that the matrix cannot be coerced back to the group:
sage: G32(g1.matrix()) Traceback (most recent call last): ... TypeError: matrix must be unitary
Change History (11)
comment:1 Changed 2 years ago by
 Branch set to u/soehms/is_unitary_for_finite_fields25716
comment:2 Changed 2 years ago by
 Branch u/soehms/is_unitary_for_finite_fields25716 deleted
 Description modified (diff)
 Status changed from new to needs_review
comment:3 Changed 2 years ago by
 Branch set to u/soehms/is_unitary_for_finite_fields25716
comment:4 Changed 2 years ago by
 Commit set to 39d8aa063ac293ecd43ec5eb6506aecdb150c3f2
Branch pushed to git repo; I updated commit sha1. New commits:
39d8aa0  typset corrections

comment:5 Changed 2 years ago by
 Branch changed from u/soehms/is_unitary_for_finite_fields25716 to u/tscrim/is_unitary_for_finite_fields25716
 Commit changed from 39d8aa063ac293ecd43ec5eb6506aecdb150c3f2 to e03959d6ed9ec24e845972cd1a5dcf7adc2518a8
 Reviewers set to Travis Scrimshaw
Thank you. I made a few trivial tweaks. If my changes look good, then positive review.
New commits:
e03959d  Some small reviewer tweaks.

comment:6 Changed 2 years ago by
 Status changed from needs_review to positive_review
Thanks for the review. I agree with your changes! I wish you successful SageDays? in Providence!
comment:7 Changed 2 years ago by
 Status changed from positive_review to needs_work
a failing doctest, guys..
comment:8 Changed 2 years ago by
 Commit changed from e03959d6ed9ec24e845972cd1a5dcf7adc2518a8 to 2cdff9fdb4344fa0829a5486a309f8151bef25ea
Branch pushed to git repo; I updated commit sha1. New commits:
2cdff9f  Trivial doctest fix due to changed error message.

comment:9 Changed 2 years ago by
 Keywords sagedays@icerm added
 Status changed from needs_work to positive_review
Thank you Sebastian. Just keep ccing me on tickets to help get your cubic braid groups code into Sage (and/or emailing me if you have any questions).
Thanks Frédéric for catching that; mea culpa. Trivial fix so I am allowing myself to set back to a positive review.
comment:10 Changed 2 years ago by
It was my fault, as well. I run a doctest yesterday evening and I saw "all tests passed", but probably in the wrong window!
Concerning the cubic braid group there is just one unreviewed ticket left (#25894) for the moment. But I will soon produce some new ones an cc you on them! Thanks for offering your help!
comment:11 Changed 2 years ago by
 Branch changed from u/tscrim/is_unitary_for_finite_fields25716 to 2cdff9fdb4344fa0829a5486a309f8151bef25ea
 Resolution set to fixed
 Status changed from positive_review to closed
I fixed the issue by implementing the method
conjugate
of the classFinitePolyExtElement