Opened 4 years ago

Closed 4 years ago

#25722 closed enhancement (fixed)

Test jupyter kernel symlinks in tmpdir

Reported by: gh-timokau Owned by:
Priority: critical Milestone: sage-8.4
Component: distribution Keywords:
Cc: jdemeyer Merged in:
Authors: Timo Kaufmann Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: a657ee2 (Commits, GitHub, GitLab) Commit: a657ee2715686449c21f9b56dfbad99a764e8b11
Dependencies: Stopgaps:

Status badges

Description

The symlink tests for the jupyter kernel currently require write permission to SAGE_SHARE. This patch instead tests the symlinking capabilities on a kernel in a tmpdir. See also #25328.

Change History (9)

comment:1 Changed 4 years ago by gh-timokau

  • Status changed from new to needs_review

comment:2 Changed 4 years ago by jdemeyer

  • Priority changed from major to critical

comment:3 Changed 4 years ago by vdelecroix

  • Milestone changed from sage-8.3 to sage-8.4

update milestone 8.3 -> 8.4

comment:4 Changed 4 years ago by gh-timokau

Jeroen would you mind reviewing this? Its a very small change with a in my opinion pretty big advantage.

comment:5 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Makes sense and LGTM, plus passing on multiple patchbots. (A stylistic bikeshed that you can fix if you don't mind: prefix = tmp_dir() -> prefix=tmp_dir())

comment:6 Changed 4 years ago by git

  • Commit changed from 86d993bbb84a43ded221d19d67970c97d25dccda to a657ee2715686449c21f9b56dfbad99a764e8b11
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

a657ee2Test kernel symlinking in tmpdir

comment:7 Changed 4 years ago by gh-timokau

Fixed, thanks for the review.


New commits:

a657ee2Test kernel symlinking in tmpdir

comment:8 Changed 4 years ago by gh-timokau

  • Status changed from needs_review to positive_review

Since it was just a whitespace change...

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/gh-timokau/ipython-test-in-tmpdir to a657ee2715686449c21f9b56dfbad99a764e8b11
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.