Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#25720 closed defect (fixed)

py3: correct recent bad import for Queue

Reported by: Frédéric Chapoton Owned by:
Priority: blocker Milestone: sage-8.3
Component: geometry Keywords:
Cc: gh-FlorentinJ, Eric Gourgoulhon, Travis Scrimshaw Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c940426 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

from #25438

Change History (9)

comment:1 Changed 4 years ago by Frédéric Chapoton

Branch: u/chapoton/25720
Commit: c940426381a969dde110a0350c54900cc8ffd750
Status: newneeds_review

Please review this. This is a fix for a python3 regression introduced in #25438, I think.


New commits:

c940426using python3 compatible imports !!

comment:2 Changed 4 years ago by Frédéric Chapoton

ping ?

comment:3 Changed 4 years ago by Frédéric Chapoton

Cc: Travis Scrimshaw added

Travis, maybe you can help here too ? This bothers me a lot (python3 regression, you know).

comment:4 Changed 4 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:5 Changed 4 years ago by Eric Gourgoulhon

Sorry about this. I of course agree with the positive review.

comment:6 Changed 4 years ago by Eric Gourgoulhon

Priority: majorblocker

Setting to "blocker" to get the attention of the release manager, before Sage 8.3 goes out.

comment:7 Changed 4 years ago by Eric Gourgoulhon

Type: enhancementdefect

comment:8 Changed 4 years ago by Volker Braun

Branch: u/chapoton/25720c940426381a969dde110a0350c54900cc8ffd750
Resolution: fixed
Status: positive_reviewclosed

comment:9 in reply to:  8 Changed 4 years ago by Eric Gourgoulhon

Commit: c940426381a969dde110a0350c54900cc8ffd750

Thank you Volker!

Note: See TracTickets for help on using tickets.