Opened 17 months ago

Closed 16 months ago

Last modified 16 months ago

#25720 closed defect (fixed)

py3: correct recent bad import for Queue

Reported by: chapoton Owned by:
Priority: blocker Milestone: sage-8.3
Component: geometry Keywords:
Cc: gh-FlorentinJ, egourgoulhon, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c940426 (Commits) Commit:
Dependencies: Stopgaps:

Description

from #25438

Change History (9)

comment:1 Changed 17 months ago by chapoton

  • Branch set to u/chapoton/25720
  • Commit set to c940426381a969dde110a0350c54900cc8ffd750
  • Status changed from new to needs_review

Please review this. This is a fix for a python3 regression introduced in #25438, I think.


New commits:

c940426using python3 compatible imports !!

comment:2 Changed 17 months ago by chapoton

ping ?

comment:3 Changed 17 months ago by chapoton

  • Cc tscrim added

Travis, maybe you can help here too ? This bothers me a lot (python3 regression, you know).

comment:4 Changed 17 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 17 months ago by egourgoulhon

Sorry about this. I of course agree with the positive review.

comment:6 Changed 16 months ago by egourgoulhon

  • Priority changed from major to blocker

Setting to "blocker" to get the attention of the release manager, before Sage 8.3 goes out.

comment:7 Changed 16 months ago by egourgoulhon

  • Type changed from enhancement to defect

comment:8 follow-up: Changed 16 months ago by vbraun

  • Branch changed from u/chapoton/25720 to c940426381a969dde110a0350c54900cc8ffd750
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 in reply to: ↑ 8 Changed 16 months ago by egourgoulhon

  • Commit c940426381a969dde110a0350c54900cc8ffd750 deleted

Thank you Volker!

Note: See TracTickets for help on using tickets.