Opened 5 years ago

Closed 5 years ago

#25715 closed defect (fixed)

Minor bugs in q_analogues parents

Reported by: mathzeta2 Owned by:
Priority: major Milestone: sage-8.3
Component: combinatorics Keywords: days94, q-analogs
Cc: ​tscrim Merged in:
Authors: Tomer Bauer Reviewers: Friedrich Wiemer
Report Upstream: N/A Work issues:
Branch: 8db491c (Commits, GitHub, GitLab) Commit: 8db491c1d5d9d2be5adafd7ff8462a96a8ead286
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description

Few Minor bugs fixes for q_analogues.q_subgroups_of_abelian_group:

  • Counting how many trivial subgroups there are (i.e. 1) was missing, and raised an exception.
  • The algorithm="delsarte" did not use floor division, so the parent is a fraction field instead of a polynomial ring.

In addition, some better support for non-Sage elements, like it is done in q_binomial, using parent(X) instead of X.parent().

Change History (5)

comment:1 Changed 5 years ago by mathzeta2

Branch: u/mathzeta2/q_subgroups_of_abelian_group_trivial
Commit: 8db491c1d5d9d2be5adafd7ff8462a96a8ead286
Status: newneeds_review

comment:2 Changed 5 years ago by asante

Reviewers: Friedrich Wiemer
Status: needs_reviewneeds_work

You should put your name as an author ;)

Apart from that LGTM.

comment:3 Changed 5 years ago by mathzeta2

Authors: Tomer Bauer
Status: needs_workneeds_review

comment:4 Changed 5 years ago by asante

Status: needs_reviewpositive_review

comment:5 Changed 5 years ago by vbraun

Branch: u/mathzeta2/q_subgroups_of_abelian_group_trivial8db491c1d5d9d2be5adafd7ff8462a96a8ead286
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.