Minor bugs in q_analogues parents
Few Minor bugs fixes for q_analogues.q_subgroups_of_abelian_group
:
 Counting how many trivial subgroups there are (i.e. 1) was missing, and raised an exception.
 The
algorithm="delsarte"
did not use floor division, so the parent is a fraction field instead of a polynomial ring.
In addition, some better support for nonSage elements, like it is done in q_binomial, using parent(X)
instead of X.parent()
.
Change History (5)
Branch: 
→ u/mathzeta2/q_subgroups_of_abelian_group_trivial

Commit: 
→ 8db491c1d5d9d2be5adafd7ff8462a96a8ead286

Status: 
new →
needs_review

Reviewers: 
→ Friedrich Wiemer

Status: 
needs_review →
needs_work

Authors: 
→ Tomer Bauer

Status: 
needs_work →
needs_review

Status: 
needs_review →
positive_review

Branch: 
u/mathzeta2/q_subgroups_of_abelian_group_trivial →
8db491c1d5d9d2be5adafd7ff8462a96a8ead286

Resolution: 
→ fixed

Status: 
positive_review →
closed

You should put your name as an author ;)
Apart from that LGTM.