Opened 2 years ago

Closed 2 years ago

#25708 closed enhancement (fixed)

Rename SBox methods for difference_distribution_matrix and similar to _table

Reported by: asante Owned by: asante
Priority: minor Milestone: sage-8.5
Component: cryptography Keywords: sbox, ddt/lat/bct, days94
Cc: ruhm Merged in:
Authors: Friedrich Wiemer Reviewers: Rusydi H. Makarim
Report Upstream: N/A Work issues:
Branch: d7cf353 (Commits) Commit: d7cf353036456dd5d6cfa6ac2729bbc9d31f1882
Dependencies: Stopgaps:

Description

The SBox class defines three methods (difference_distribution_matrix, linear_approximation_matrix and boomerang_connectivity_matrix) that are typically called ..._table in the literature.

IMO we should adjust these names (and correctly deprecate the old names, of course).

Change History (18)

comment:1 Changed 2 years ago by asante

  • Branch set to u/asante/rename_sbox_methods_for_difference_distribution_matrix_and_similar_to__table

comment:2 Changed 2 years ago by asante

  • Authors set to Friedrich Wiemer
  • Cc ruhm added
  • Commit set to 7ef7a5cf6e4a81737e3d08d9aac7813b7420bcef
  • Owner changed from (none) to asante

New commits:

​da623abrenamed DDT/LAT/BCT methods
​7ef7a5cproperly deprecate class methods

comment:3 Changed 2 years ago by asante

  • Status changed from new to needs_review

comment:4 Changed 2 years ago by ruhm

  • Reviewers set to Rusydi H. Makarim
  • Status changed from needs_review to needs_work

Hi Friedrich,

You forgot to apply similar changes for autocorrelation_matrix.

comment:5 Changed 2 years ago by git

  • Commit changed from 7ef7a5cf6e4a81737e3d08d9aac7813b7420bcef to 1ad26b57ed0b74ce7180d56fb3764f1d72cd6aa9

Branch pushed to git repo; I updated commit sha1. New commits:

​1ad26b5rename autocorrelation_matrix to _table, too,

comment:6 Changed 2 years ago by asante

  • Status changed from needs_work to needs_review

comment:7 Changed 2 years ago by git

  • Commit changed from 1ad26b57ed0b74ce7180d56fb3764f1d72cd6aa9 to 57cedbf7f7b453fa78bb5cdbc26cff2f1802661e

Branch pushed to git repo; I updated commit sha1. New commits:

​57cedbfMerge branch 'develop' into t/25708/rename_sbox_methods_for_difference_distribution_matrix_and_similar_to__table

comment:8 Changed 2 years ago by ruhm

Hi Friedrich,

So far looks good to me. There is only one thing left. The documentation of crypto/mq/sr.py mentioned difference_distribution_matrix. I think that too needs to be replaced.

comment:9 Changed 2 years ago by ruhm

  • Status changed from needs_review to needs_work

comment:10 Changed 2 years ago by git

  • Commit changed from 57cedbf7f7b453fa78bb5cdbc26cff2f1802661e to d5c318140c8c508e7d1d74a10cd302552c071079

Branch pushed to git repo; I updated commit sha1. New commits:

​d5c3181change DDM reference in sr.py to DDT

comment:11 Changed 2 years ago by asante

  • Status changed from needs_work to positive_review

comment:12 Changed 2 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:13 Changed 2 years ago by git

  • Commit changed from d5c318140c8c508e7d1d74a10cd302552c071079 to e57739ddd69f1326b1c4f74d73549b69832f8a5e

Branch pushed to git repo; I updated commit sha1. New commits:

​e57739dMerge branch 'develop' into t/25708/rename_sbox_methods_for_difference_distribution_matrix_and_similar_to__table

comment:14 Changed 2 years ago by asante

  • Milestone changed from sage-8.3 to sage-8.4
  • Status changed from needs_work to needs_review

comment:15 Changed 2 years ago by asante

  • Milestone changed from sage-8.4 to sage-8.5

comment:16 Changed 2 years ago by git

  • Commit changed from e57739ddd69f1326b1c4f74d73549b69832f8a5e to d7cf353036456dd5d6cfa6ac2729bbc9d31f1882

Branch pushed to git repo; I updated commit sha1. New commits:

​d7cf353Merge branch 'develop' into t/25708/rename_sbox_methods_for_difference_distribution_matrix_and_similar_to__table

comment:17 Changed 2 years ago by asante

  • Status changed from needs_review to positive_review

Setting to positive review, as Rusydi was fine with it and I only fixed the merge conflict.

comment:18 Changed 2 years ago by vbraun

  • Branch changed from u/asante/rename_sbox_methods_for_difference_distribution_matrix_and_similar_to__table to d7cf353036456dd5d6cfa6ac2729bbc9d31f1882
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.