Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#25705 closed enhancement (fixed)

Make libhomfly and libbraiding standard packages.

Reported by: mmarco Owned by:
Priority: major Milestone: sage-8.4
Component: packages: standard Keywords: days94
Cc: tscrim, jdemeyer Merged in:
Authors: Miguel Marco Reviewers: Jeroen Demeyer, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 456cb3c (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

As was discussed in https://groups.google.com/forum/#!topic/sage-devel/9BhrS2J4oE8 these two packages have been optional for over a year. They provide useful methods for braids and links.

Change History (13)

comment:1 Changed 4 years ago by mmarco

  • Branch set to u/mmarco/make_libhomfly_and_libbraiding_standard_packages_

comment:2 Changed 4 years ago by mmarco

  • Commit set to 34542a470ff8235f6db2e1f1a3dbd3879441f156
  • Status changed from new to needs_review

New commits:

34542a4Make libbraiding and libhomfly standard packages

comment:3 Changed 4 years ago by jdemeyer

  • Component changed from algebraic topology to packages: standard
  • Reviewers set to Jeroen Demeyer

comment:4 Changed 4 years ago by git

  • Commit changed from 34542a470ff8235f6db2e1f1a3dbd3879441f156 to 456cb3c532c146127cfc1bcde3ec49196b605f6a

Branch pushed to git repo; I updated commit sha1. New commits:

456cb3cRemove optional tag from some doctests, and warnings

comment:5 Changed 4 years ago by tscrim

Since the vote was 2:0 for inclusion with no objections, I would say we should change this to a positive review.

comment:6 Changed 4 years ago by mmarco

  • Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, Travis Scrimshaw
  • Status changed from needs_review to positive_review

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/mmarco/make_libhomfly_and_libbraiding_standard_packages_ to 456cb3c532c146127cfc1bcde3ec49196b605f6a
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 follow-up: Changed 4 years ago by gh-timokau

  • Commit 456cb3c532c146127cfc1bcde3ec49196b605f6a deleted

In the future, I'd appreciate if you could cross-post such a vote to sage-packaging. No accusation, just a friendly request :)

I now have to package these two libraries for nix. Questions:

  • where is the source for libbraiding 1.0 coming from? I'm assuming its from https://github.com/miguelmarco/libbraiding/, but I don't see any tagged 1.0 release or a linked distribution tarball there.
  • why are we using this fork instead of any other? The jeanluct has more recent commits for example. Since you're apparently the author I'm sure you have good reasons, but you should document them.

comment:9 in reply to: ↑ 8 ; follow-up: Changed 4 years ago by mmarco

Replying to gh-timokau:

In the future, I'd appreciate if you could cross-post such a vote to sage-packaging. No accusation, just a friendly request :)

Ok, I will try to remember that the next time.

I now have to package these two libraries for nix. Questions:

Yes, the source is taken from the github repo (I know the correct way to do would be to create a release... Add it to my to-do list)

  • why are we using this fork instead of any other? The jeanluct has more recent commits for example. Since you're apparently the author I'm sure you have good reasons, but you should document them.

jeanluct's repo contains a command line program (braiding). libbraiding is not a command line program, but a library that exposes the functions to be used by other programs.

comment:10 in reply to: ↑ 9 Changed 4 years ago by gh-timokau

Replying to mmarco:

I now have to package these two libraries for nix. Questions:

Yes, the source is taken from the github repo (I know the correct way to do would be to create a release... Add it to my to-do list)

Ah okay, makes sense. I think you should add that explanation to the README sentence where you mention its a fork.

  • why are we using this fork instead of any other? The jeanluct has more recent commits for example. Since you're apparently the author I'm sure you have good reasons, but you should document them.

jeanluct's repo contains a command line program (braiding). libbraiding is not a command line program, but a library that exposes the functions to be used by other programs.

Could you please do that soon? Just add a 1.0 tag to github. Shouldn't take more than a minute. Its not very nice to package something without an offical source.

comment:11 Changed 4 years ago by mmarco

I created the release in github. However, the tarball that you will get there does not coincide with the one in the sage repo, since the later is constructed from the former by autotools.

comment:12 Changed 4 years ago by gh-timokau

Thank you. That is no problem, we can just run autotools ourselves in the build scripts. I prefer that anyways (I feel like the generated makefiles and configure scripts are close to distributed binaries).

comment:13 Changed 4 years ago by embray

  • Milestone changed from sage-8.3 to sage-8.4

Can we please retarget tickets' milestones either before a milestone is marked completed, or shortly thereafter (or at least certainly before closing a ticket...)?

Note: See TracTickets for help on using tickets.