Opened 2 years ago

Closed 23 months ago

#25695 closed defect (fixed)

Miscellaneous code cleanup in sage.misc.dev_tools

Reported by: embray Owned by:
Priority: minor Milestone: sage-8.3
Component: misc Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 1891333 (Commits) Commit: 1891333084f982746995a2f1501a8cade61b025e
Dependencies: Stopgaps:

Description

A little bit of PEP-8 cleanup in this module and other code modernizations. This does fix one bug, which was made apparent in the Python 3 doctests, where the local variable module_name in import_statements wasn't treated properly since it was also used as a loop variable, leading to strange bugs.

Change History (5)

comment:1 Changed 2 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 2 years ago by chapoton

  • Status changed from needs_review to positive_review

ok

comment:3 Changed 2 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name...

comment:4 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_work to positive_review

comment:5 Changed 23 months ago by vbraun

  • Branch changed from u/embray/misc/dev_tools/misc-cleanup to 1891333084f982746995a2f1501a8cade61b025e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.