Opened 5 years ago

Closed 5 years ago

#25634 closed enhancement (fixed)

adding "number_of_roots_of_unity" in quadratic fields

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.3
Component: number fields Keywords:
Cc: annahaensch, sbrandhorst Merged in:
Authors: Frédéric Chapoton Reviewers: Alex J. Best
Report Upstream: N/A Work issues:
Branch: 1901a14 (Commits, GitHub, GitLab) Commit: 1901a144ee7dbaf8fb9da93943c998f5a4e93674
Dependencies: Stopgaps:

Status badges

Description

because this is slightly faster

and also correcting invalid escape sequence there

Change History (6)

comment:1 Changed 5 years ago by chapoton

Branch: → u/chapoton/25634
Commit: → 1901a144ee7dbaf8fb9da93943c998f5a4e93674
Status: new → needs_review

New commits:

​1901a14adding a direct method "number_of_roots_of_unity" for quadratic fields

comment:2 Changed 5 years ago by chapoton

Cc: annahaensch sbrandhorst added

a rather trivial ticket, should be an easy review, please.

comment:3 Changed 5 years ago by alexjbest

Status: needs_review → positive_review

Ok!

comment:4 Changed 5 years ago by alexjbest

Reviewers: → Alex J. Best

comment:5 Changed 5 years ago by chapoton

Thanks a lot.

comment:6 Changed 5 years ago by vbraun

Branch: u/chapoton/25634 → 1901a144ee7dbaf8fb9da93943c998f5a4e93674
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.