Opened 4 years ago

Closed 4 years ago

#25608 closed enhancement (fixed)

Further clean up of libGAP declarations

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.3
Component: cython Keywords:
Cc: dimpase Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 44b9ee0 (Commits, GitHub, GitLab) Commit: 44b9ee03c32890456b017ba60f132b3b6be14716
Dependencies: Stopgaps:

Status badges

Description

Use the model from most other libraries.

Change History (8)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/further_clean_up_of_libgap_declarations

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to 44b9ee03c32890456b017ba60f132b3b6be14716
  • Status changed from new to needs_review

New commits:

​44b9ee0Further clean up of libGAP declarations

comment:3 Changed 4 years ago by dimpase

Does one need to do anything special besides running make to test this update?

comment:4 Changed 4 years ago by jdemeyer

Run the GAP-related doctests I suppose...

comment:5 Changed 4 years ago by tscrim

Dima, are you in the process of reviewing this?

comment:6 Changed 4 years ago by dimpase

I am in the process of marking 70 exam scripts...

comment:7 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Okay. This LGTM.

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/further_clean_up_of_libgap_declarations to 44b9ee03c32890456b017ba60f132b3b6be14716
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.