Opened 4 years ago

Closed 4 years ago

#25591 closed enhancement (fixed)

py3: adding hash functions for Laurent polys, Toric var. and overconvergent forms

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.3
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 3760a83 (Commits, GitHub, GitLab) Commit: 3760a838298163b61be2aec356de0ac336bfcffb
Dependencies: Stopgaps:

Status badges

Description


Change History (8)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/25591
  • Commit set to 8ffe0552869cfa8c0f67495f718a7df607b8e1e7
  • Status changed from new to needs_review

New commits:

8ffe055adding 3 hash functions : LaurentPoly, Overconvergent forms, Toric

comment:2 Changed 4 years ago by vdelecroix

For Laurent polynomial ring it is not a good idea to give it the same hash as the underlying multi-polynomial ring. You would better xor it with a random number

    return hash(self._R) ^ 12059065606945654693

comment:3 Changed 4 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to needs_work

comment:4 Changed 4 years ago by git

  • Commit changed from 8ffe0552869cfa8c0f67495f718a7df607b8e1e7 to 3760a838298163b61be2aec356de0ac336bfcffb

Branch pushed to git repo; I updated commit sha1. New commits:

3760a83fixing hash of LaurentPolynomial rings

comment:5 Changed 4 years ago by chapoton

  • Status changed from needs_work to needs_review

Merci. C'est fait.

comment:6 Changed 4 years ago by vdelecroix

you use 8.3.beta5 before it is announced :-)

comment:7 Changed 4 years ago by vdelecroix

  • Status changed from needs_review to positive_review

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/25591 to 3760a838298163b61be2aec356de0ac336bfcffb
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.