#25588 closed enhancement (fixed)

Dimension of poset with certificate

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-8.3
Component: combinatorics Keywords:
Cc: chapoton, tscrim Merged in:
Authors: Jori Mäntysalo Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 064844b (Commits) Commit: 064844b2efd2b7e25f3405db7509c64ac588374d
Dependencies: Stopgaps:

Description

Currently .dimension(certificate=True) returns only realizer, not a pair having a realizer as second element. Compare to, for example, .height(certificate=True). Change this.

Change History (7)

comment:1 Changed 18 months ago by jmantysalo

  • Branch set to u/jmantysalo/dimension_of_poset_with_certificate

comment:2 Changed 18 months ago by jmantysalo

  • Cc chapoton tscrim added
  • Commit set to 3b7e5b9bb7daf3d7b134146a9e6ba4c24a1bdf9d
  • Status changed from new to needs_review

More to come with #25562, but this should be the only patch doing a possible unpleasant change to the interface.


New commits:

3b7e5b9Return a pair when certificate requested.

comment:3 follow-up: Changed 18 months ago by chapoton

you may add a link to the ticket here using :trac:

comment:4 Changed 18 months ago by git

  • Commit changed from 3b7e5b9bb7daf3d7b134146a9e6ba4c24a1bdf9d to 064844b2efd2b7e25f3405db7509c64ac588374d

Branch pushed to git repo; I updated commit sha1. New commits:

064844bAdd trac link.

comment:5 in reply to: ↑ 3 Changed 18 months ago by jmantysalo

Replying to chapoton:

you may add a link to the ticket here using :trac:

Like this?

comment:6 Changed 18 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:7 Changed 18 months ago by vbraun

  • Branch changed from u/jmantysalo/dimension_of_poset_with_certificate to 064844b2efd2b7e25f3405db7509c64ac588374d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.