Opened 4 years ago

Closed 4 years ago

#25576 closed enhancement (fixed)

allow to use certificate for poset is_isomorphic

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.3
Component: combinatorics Keywords:
Cc: jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: d13de9d (Commits, GitHub, GitLab) Commit: d13de9d051385f419e159b402ccc1e979a5ddcd8
Dependencies: Stopgaps:

Status badges

Description (last modified by tscrim)

by adding **kwds in the call of the method of Hasse diagrams

Change History (8)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/25576
  • Commit set to 2dd9592c9cfb8106dbda3994802831b957d41c36
  • Status changed from new to needs_review

New commits:

​2dd9592poset isomorphism can be required

comment:2 Changed 4 years ago by git

  • Commit changed from 2dd9592c9cfb8106dbda3994802831b957d41c36 to f25d48e9824430763912911bfb0d3dae7f75b7ea

Branch pushed to git repo; I updated commit sha1. New commits:

​f25d48etrac 25576 fixing pyflakes

comment:3 Changed 4 years ago by jmantysalo

This clearly works.

However, which parameters are usefull from graphs? Should we have just certificate-option?

Another thing, is it faster to compare _hasse_diagram instead of hasse_diagram()?

comment:4 Changed 4 years ago by tscrim

  • Description modified (diff)

While I agree with Jori that it probably should be _hasse_diagram, that is outside of the scope of this ticket. (In fact, there are probably a few things that should be tweaks with that and/or have it lifted to the category.)

However, I think the generic **kwds is better than anything explicit because it is more future-proof and gives the user more flexibility.

One nitpick: could you add a reference to this ticket as part of the TESTS::?

comment:5 Changed 4 years ago by git

  • Commit changed from f25d48e9824430763912911bfb0d3dae7f75b7ea to d13de9d051385f419e159b402ccc1e979a5ddcd8

Branch pushed to git repo; I updated commit sha1. New commits:

​d13de9dtrac 25576 adding trac role

comment:6 Changed 4 years ago by chapoton

Thanks, done

Last edited 4 years ago by chapoton (previous) (diff)

comment:7 Changed 4 years ago by tscrim

  • Reviewers set to Jori Mäntysalo, Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thanks.

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/25576 to d13de9d051385f419e159b402ccc1e979a5ddcd8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.