Opened 13 years ago

Closed 13 years ago

#2553 closed defect (fixed)

[with patch, positive review] dsage unit tests fail on linux

Reported by: yi Owned by: yi
Priority: blocker Milestone: sage-3.0
Component: dsage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Various users have reported that the dsage unit tests fail on linux. This is a known issue and a fix is being worked on by me.

Attachments (4)

dsage_unittest_2553.patch (795 bytes) - added by yi 13 years ago.
pb_unittest.patch (13.8 KB) - added by yi 13 years ago.
fixes unit tests on linux 32bit.
pb_unittest.2.patch (14.3 KB) - added by yi 13 years ago.
This patch should apply cleanly against 3.0.alpha5.
scripts-2553.patch (653 bytes) - added by was 13 years ago.
also apply this to the scripts repo

Download all attachments as: .zip

Change History (10)

Changed 13 years ago by yi

comment:1 Changed 13 years ago by yi

This patch disables the unit tests when people run the tests using the sage-maketest script.

Changed 13 years ago by yi

fixes unit tests on linux 32bit.

comment:2 Changed 13 years ago by yi

  • Summary changed from dsage unit tests fail on linux to [with patch, needs review] dsage unit tests fail on linux

Attached pb_unittest.patch which should fix the unittest failures on 32bit machines.

comment:3 Changed 13 years ago by mhansen

pb_unittest.patch does not apply cleanly for me with 3.0.alpha1

Changed 13 years ago by yi

This patch should apply cleanly against 3.0.alpha5.

Changed 13 years ago by was

also apply this to the scripts repo

comment:4 Changed 13 years ago by was

  • Summary changed from [with patch, needs review] dsage unit tests fail on linux to [with patch, positive review] dsage unit tests fail on linux

REFEREE REPORT:

I tested this on a bunch of platforms and it works.

I read the code and it looks sane.

COMPLAINT: there is not a *single* line of documentation or comments anywhere that explain why the new version works when the original didn't or what is going on. Shame! But I still give this a positive review so we can start testing again.

TO USE: Apply pb_unittest.2.patch to hg_sage and scripts-2553.patch to hg_scripts

comment:5 Changed 13 years ago by was

  • Milestone changed from sage-3.0.1 to sage-3.0
  • Priority changed from major to blocker

comment:6 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged pb_unittest.2.patch and scripts-2553.patch in Sage 3.0.rc1

Note: See TracTickets for help on using tickets.