Opened 17 months ago

Closed 16 months ago

#25521 closed enhancement (fixed)

pyflakes cleanup in plot/plot.py

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.3
Component: graphics Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 12305a6 (Commits) Commit: 12305a6004710ebe420baa869b51aa9ec335961d
Dependencies: Stopgaps:

Description (last modified by chapoton)

on the way, removing a whole set of old alias imports.

Change History (12)

comment:1 Changed 17 months ago by chapoton

  • Branch set to u/chapoton/25521
  • Commit set to 4554a54431e8f2ccec54188bdef9fa1eba5a4358
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​4554a54pyflakes cleanup of plot/plot.py

comment:2 Changed 17 months ago by git

  • Commit changed from 4554a54431e8f2ccec54188bdef9fa1eba5a4358 to 6aad51ba50286128c0ed5508cd573e4157dd3a4b

Branch pushed to git repo; I updated commit sha1. New commits:

​6aad51bfix some imports

comment:3 Changed 17 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 17 months ago by chapoton

thanks, Travis ; But maybe we should wait for a green patchbot ?

comment:5 Changed 17 months ago by tscrim

  • Status changed from positive_review to needs_work

Indeed, the patchbot did come back with issues.

comment:6 Changed 17 months ago by git

  • Commit changed from 6aad51ba50286128c0ed5508cd573e4157dd3a4b to a0be77fdbb1fe0edffc26a2c20754124a8a4bf86

Branch pushed to git repo; I updated commit sha1. New commits:

​a0be77ffixing a few imports

comment:7 Changed 17 months ago by git

  • Commit changed from a0be77fdbb1fe0edffc26a2c20754124a8a4bf86 to 2becab095d73c7b1e5f4277ee15e78c93e26b564

Branch pushed to git repo; I updated commit sha1. New commits:

​2becab0fix more imports

comment:8 Changed 17 months ago by git

  • Commit changed from 2becab095d73c7b1e5f4277ee15e78c93e26b564 to 12305a6004710ebe420baa869b51aa9ec335961d

Branch pushed to git repo; I updated commit sha1. New commits:

​12305a6more details / pyflakes

comment:9 Changed 16 months ago by chapoton

ok. not perfect, but good enough maybe ?

comment:10 Changed 16 months ago by chapoton

  • Status changed from needs_work to needs_review

comment:11 Changed 16 months ago by tscrim

  • Status changed from needs_review to positive_review

We can always do more on later tickets.

comment:12 Changed 16 months ago by vbraun

  • Branch changed from u/chapoton/25521 to 12305a6004710ebe420baa869b51aa9ec335961d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.