Add is_square method to LaurentPolynomial_univariate class

[vklein]

Add an is_square instance method to LaurentPolynomial_univariate class.

This ticket is a prerequisite for #24677.

[vdelecroix]

New commits:

​4ab32e2	24523: "Real Field" -> "Real Floating-point Field"
​b2fa88c	25512: is_square for Laurent polynomials

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​193df32

25512: is_square for Laurent polynomials

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​2ff8818

25512: is_square for Laurent polynomials

[tscrim]

While this

return (True, LaurentPolynomial_univariate(self._parent, r, self.__n // 2))

is okay for now, it is not future-proof if we have a subclass of LaurentPolynomial_univariate. It would be better to do

return (True, type(self)(self._parent, r, self.__n // 2))

Bikeshedding (so feel free to ignore), but I'd rather see elif root: -> if root: to better indicate that the previous block is meant to stop.

[vdelecroix]

Replying to tscrim:

While this

return (True, LaurentPolynomial_univariate(self._parent, r, self.__n // 2))

is okay for now, it is not future-proof if we have a subclass of LaurentPolynomial_univariate.

On the other hand, all other methods create new Laurent polynomial this way. I don't have any strong opinion on the way it should be done but I have a strong opinion on the fact that it should be the same in all methods. If you feel like it has to change, it would better be part of another ticket as I don't want to modify other methods.

It would be better to do

return (True, type(self)(self._parent, r, self.__n // 2))

Bikeshedding (so feel free to ignore), but I'd rather see elif root: -> if root: to better indicate that the previous block is meant to stop.

For this I don't agree. It is much easier to read a if/elif/elif/else rather a if/if/if/if where you have to think whether the other blocks meant to stopped.

[tscrim]

Replying to vdelecroix:

Replying to tscrim:

While this

return (True, LaurentPolynomial_univariate(self._parent, r, self.__n // 2))

is okay for now, it is not future-proof if we have a subclass of LaurentPolynomial_univariate.

On the other hand, all other methods create new Laurent polynomial this way. I don't have any strong opinion on the way it should be done but I have a strong opinion on the fact that it should be the same in all methods. If you feel like it has to change, it would better be part of another ticket as I don't want to modify other methods.

I have a strong opinion that it should be done this way and to not to make things worse on new code. Doing things a bad way just because it was done that way in the past is not a good argument.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​5e1cadf

25512: _new_c method + various cleaning

[vdelecroix]

Replying to tscrim:

Replying to vdelecroix:

Replying to tscrim:

While this

return (True, LaurentPolynomial_univariate(self._parent, r, self.__n // 2))

is okay for now, it is not future-proof if we have a subclass of LaurentPolynomial_univariate.

On the other hand, all other methods create new Laurent polynomial this way. I don't have any strong opinion on the way it should be done but I have a strong opinion on the fact that it should be the same in all methods. If you feel like it has to change, it would better be part of another ticket as I don't want to modify other methods.

I have a strong opinion that it should be done this way and to not to make things worse on new code. Doing things a bad way just because it was done that way in the past is not a good argument.

Now it is clean :-)

[vdelecroix]

But apparently something is not working anymore... (or Iwahori Hecke algebra did use some forbidden features)

[vdelecroix]

Cleaning (#25524) is set as a dependency.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​028a39e	25524: cleaning Laurent polynomials
​20291d8	25524: some fixes to sage/algebras
​9cacb5a	25524: fix doctests in algebras
​093d8a3	25512: is_square for Laurent polynomial

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​2c41847	25524: cleaning Laurent polynomials
​19ca666	25524: some fixes to sage/algebras
​a9b43eb	25524: fix doctests in algebras
​228529a	25524: add linebreak to doctests
​7e3870d	25512: is_square for Laurent polynomial

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​ea27dde

25512: is_square for univariate Laurent polynomial

[tscrim]

LGTM. Thank you.