Changes between Version 6 and Version 7 of Ticket #25511


Ignore:
Timestamp:
06/06/18 09:52:43 (3 years ago)
Author:
SimonKing
Comment:

Replying to jdemeyer:

  1. The class Matrix_gfpn_dense has a special (and undocumented!)

I have an example for it in the doctests, but admittedly in the beginning of the docstring of __init__ it isn't mentioned.

  1. Add a new function new_from_meataxe to create a new Matrix_gfpn_dense from a meataxe Matrix_t* and use it where applicable.

That'd certainly be useful. IIRC I have such functions in my cohomology code, but certainly they'd belong here.

  1. Remove self._cache = {} and self._is_immutable = False where possible because those shouldn't be needed.

Why? Because Cython would automatically initialise a cdef dict attribute to an empty dict?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25511 – Description

    v6 v7  
    111. The class `Matrix_gfpn_dense` has a special (and undocumented!) constructor to create a matrix from a filename. This is a very special case because it is the only case where the first argument is ''not'' the parent (the matrix space). Because of this special case, some optimizations that I plan to do in #25505 become harder. Instead, this constructor from a filename is changed to a classmethod `Matrix_gfpn_dense.from_filename()`.
    22
    3 2. Add a new function `new_mtx` to create a new `Matrix_gfpn_dense` from a meataxe `Matrix_t*` and use it where applicable. This simplifies a lot of existing code.
     32. Add a new function `new_from_meataxe` to create a new `Matrix_gfpn_dense` from a meataxe `Matrix_t*` and use it where applicable.
    44
    553. Remove `self._cache = {}` and `self._is_immutable = False` where possible because those shouldn't be needed.