Changes between Version 4 and Version 5 of Ticket #25511


Ignore:
Timestamp:
06/06/18 09:25:24 (3 years ago)
Author:
jdemeyer
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25511

    • Property Summary changed from Get rid of the Matrix_gfpn_dense(filename) constructor to Clean up creating Matrix_gfpn_dense matrices
  • Ticket #25511 – Description

    v4 v5  
    1 The class `Matrix_gfpn_dense` has a special (and undocumented!) constructor to create a matrix from a filename. This is a very special case because it is the only case where the first argument is ''not'' the parent (the matrix space). Because of this special case, some optimizations that I plan to do in #25505 become harder.
     11. The class `Matrix_gfpn_dense` has a special (and undocumented!) constructor to create a matrix from a filename. This is a very special case because it is the only case where the first argument is ''not'' the parent (the matrix space). Because of this special case, some optimizations that I plan to do in #25505 become harder. Instead, this constructor from a filename is changed to a classmethod `Matrix_gfpn_dense.from_filename()`.
    22
    3 Instead, this constructor from a filename is changed to a classmethod `Matrix_gfpn_dense.from_filename()`.
     32. Add a new function `new_from_meataxe` to create a new `Matrix_gfpn_dense` from a meataxe `Matrix_t*` and use it where applicable.
     4
     53. Remove `self._cache = {}` and `self._is_immutable = False` where possible because those shouldn't be needed.