Changes between Initial Version and Version 2 of Ticket #25511


Ignore:
Timestamp:
06/06/18 08:56:51 (3 years ago)
Author:
jdemeyer
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25511

    • Property Summary changed from Can we get rid of the Matrix_gfpn_dense(filename) constructor? to Get rid of the Matrix_gfpn_dense(filename) constructor
    • Property Authors changed from to Jeroen Demeyer
  • Ticket #25511 – Description

    initial v2  
    11The class `Matrix_gfpn_dense` has a special constructor to create a matrix from a filename. This is a very special case because it is the only case where the first argument is ''not'' the parent (the matrix space). Because of this special case, some optimizations that I plan to do in #25505 become harder.
    22
    3 So can we instead require that the first argument when constructing a matrix is always the parent? We can still allow creating a `Matrix_gfpn_dense` from a filename using a classmethod like `Matrix_gfpn_dense.from_filename()`.
    4 
    5 This is phrased as a question because I could work around this issue if needed. However, if this filename constructor can be removed, that would make things simpler.
     3Instead, this constructor from a filename is changed to a classmethod `Matrix_gfpn_dense.read_file()`. This take a file object as argument (instead of a filename).