Opened 3 years ago

Closed 3 years ago

#25510 closed defect (fixed)

Declared coordinate range not taken into account when a symbolic bound is involved

Reported by: egourgoulhon Owned by:
Priority: major Milestone: sage-8.3
Component: geometry Keywords: manifold, coordinate chart
Cc: Dicolevrai Merged in:
Authors: Eric Gourgoulhon Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 936592d (Commits, GitHub, GitLab) Commit: 936592d7ae9b50ad4bd11e831b3dffded71b934b
Dependencies: Stopgaps:

Status badges

Description

This is OK: 

sage: M = Manifold(2, 'M')
sage: X.<x,y> = M.chart("x y:(0,1)")
sage: assumptions()
[x is real, y is real, y > 0, y < 1]

while this is bad: 

sage: forget()
sage: M = Manifold(2, 'M')
sage: a = var('a'); assume(a>0)
sage: X.<x,y> = M.chart("x y:(0,a)")
sage: assumptions()
[a > 0, x is real, y is real, y > 0]

The constraint y < a is not included in the assumption list, contrary to y < 1 in the first example. The origin of the bug is 

sage: bool(a != Infinity)
False

This is corrected by changing the tests xmin != -Infinity and xmax != Infinity to respectively not (xmin == -Infinity) and not (xmax == Infinity) in sage.manifolds.chart.RealChart._init_coordinates.

Change History (8)

comment:1 Changed 3 years ago by egourgoulhon

  • Branch set to public/manifolds/coordinate_range_assumptions_25510
  • Commit set to ebc0af92c59f1f8759c71065fe401e27d9c688fe

New commits:

​ebc0af9Fix assumptions for coordinate range declared with symbolic bounds

comment:2 Changed 3 years ago by egourgoulhon

  • Cc Dicolevrai added
  • Status changed from new to needs_review

comment:3 Changed 3 years ago by egourgoulhon

  • Summary changed from Declared range of coordinate with symbolic bounds not taken into account to Declared range of coordinate not taken into account when a symbolic bound is involved

comment:4 Changed 3 years ago by egourgoulhon

  • Summary changed from Declared range of coordinate not taken into account when a symbolic bound is involved to Declared coordinate range not taken into account when a symbolic bound is involved

comment:5 Changed 3 years ago by git

  • Commit changed from ebc0af92c59f1f8759c71065fe401e27d9c688fe to 936592d7ae9b50ad4bd11e831b3dffded71b934b

Branch pushed to git repo; I updated commit sha1. New commits:

​936592dRemove unnecessary import in chart.py + corrected some simplify code in the same file

comment:6 follow-up: Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 in reply to: ↑ 6 Changed 3 years ago by egourgoulhon

Thanks for the review!

comment:8 Changed 3 years ago by vbraun

  • Branch changed from public/manifolds/coordinate_range_assumptions_25510 to 936592d7ae9b50ad4bd11e831b3dffded71b934b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.