Opened 3 years ago

Closed 2 years ago

#25508 closed enhancement (fixed)

Implement reconstruction of binary quintics

Reported by: jnoordsij Owned by:
Priority: major Milestone: sage-9.0
Component: algebra Keywords: invariant_theory
Cc: mstreng, pbruin Merged in:
Authors: Jesper Noordsij Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: ff11a5d (Commits, GitHub, GitLab) Commit: ff11a5dbf81e097b37a8821f853ca73e02ae373c
Dependencies: Stopgaps:

Status badges

Description (last modified by jnoordsij)

Implement a function that given a set of values of invariants of a binary quintic, finds a quintic that attains these values up to scaling.

A general framework for reconstruction is implemented for quintics defined over fields of characteric different from 2, 3 and 5. This is placed in the new invariants folder created in ticket #26370.

For fields of characteristic 2, 3 and 5, see ticket #26786.

This ticket requires binary quintics for computations and doctests, so depends on #25395.

Change History (51)

comment:1 Changed 3 years ago by jnoordsij

  • Branch set to u/jnoordsij/binary_quintics_reconstruction

comment:2 Changed 3 years ago by git

  • Commit set to b80da8c1e7b8ade6c352507c547aae3db66b19dd

Branch pushed to git repo; I updated commit sha1. New commits:

3247dc5Fixed spaces and imports.
b62525aChanged invariants output & added reduced flag for output.
b80da8cSome more fixes & added files to documentation.

comment:3 Changed 3 years ago by git

  • Commit changed from b80da8c1e7b8ade6c352507c547aae3db66b19dd to 480180a674808fbfcf6e80b0deeeb7961e1d5a02

Branch pushed to git repo; I updated commit sha1. New commits:

480180aFixed a bug with infinite loop when using reduced flag.

comment:4 Changed 3 years ago by jnoordsij

  • Status changed from new to needs_review

comment:5 Changed 3 years ago by git

  • Commit changed from 480180a674808fbfcf6e80b0deeeb7961e1d5a02 to fd21650147ac926365b81024466b1c0d69d1865e

Branch pushed to git repo; I updated commit sha1. New commits:

775e8cbMerge branch 'develop' into binary_quintics_reconstruction
fd21650Fixes to ensure documentation builds after merge.

comment:6 Changed 3 years ago by jnoordsij

  • Authors set to Jesper Noordsij

comment:7 Changed 3 years ago by git

  • Commit changed from fd21650147ac926365b81024466b1c0d69d1865e to 8460b3dcff7a477bf86413f7546daab8ca7a2798

Branch pushed to git repo; I updated commit sha1. New commits:

e6646adRemoving invariant_theory.py before merge.
8460b3dMerge branch 'develop' into binary_quintics_reconstruction.

comment:8 Changed 3 years ago by git

  • Commit changed from 8460b3dcff7a477bf86413f7546daab8ca7a2798 to 8ddfe3023a2b1d845cb31a4016e2648a75946b98

Branch pushed to git repo; I updated commit sha1. New commits:

30be42fRemoving invariant_theory.py before merge.
78a30edAdjusted to fix slower startup time.
b935917Merge branch 'develop' into t/25395/binary_quintics
dc81ba3Documentation fixes.
872f8d2Merge branch 't/25395/binary_quintics' into t/25508/binary_quintics_reconstruction
0236fedSmall corrections.
8ddfe30More documentation fixes & adjusting transvectant.

comment:9 Changed 3 years ago by git

  • Commit changed from 8ddfe3023a2b1d845cb31a4016e2648a75946b98 to fd6719d3c92f16924960c1c3d18c9e05eeaf0296

Branch pushed to git repo; I updated commit sha1. New commits:

fd6719dMinor documentation fixes.

comment:10 Changed 3 years ago by git

  • Commit changed from fd6719d3c92f16924960c1c3d18c9e05eeaf0296 to 85a8383f3a57c0c5383a3a0c4ff3b569370f26e3

Branch pushed to git repo; I updated commit sha1. New commits:

85a8383Fixed pyflakes and failing doctests.

comment:11 Changed 3 years ago by jnoordsij

  • Status changed from needs_review to needs_work
  • Work issues set to fix doctests where deprecation errors appear

comment:12 Changed 3 years ago by git

  • Commit changed from 85a8383f3a57c0c5383a3a0c4ff3b569370f26e3 to 2501a4e3eef93fba4fb2a40f0bf8d220dd95eb01

Branch pushed to git repo; I updated commit sha1. New commits:

ff5f1b9Changed import to lazy_import and moved two imports.
2501a4eAdjusted imports of invariant_theory to new file location.

comment:13 Changed 3 years ago by jnoordsij

  • Status changed from needs_work to needs_review
  • Work issues fix doctests where deprecation errors appear deleted

comment:14 Changed 3 years ago by git

  • Commit changed from 2501a4e3eef93fba4fb2a40f0bf8d220dd95eb01 to 0e27dc115ee56fe93e6ccd7cba50530aedca5e52

Branch pushed to git repo; I updated commit sha1. New commits:

0e27dc1Final doctest fixed.

comment:15 Changed 3 years ago by mstreng

  • Cc pbruin added

comment:16 Changed 3 years ago by mstreng

  • Status changed from needs_review to needs_work

I'm setting this to needs_work, since it depends on #25395, which currently needs work. When you set #25395 back to needs_review, if you think #25508 is ready for review, you can set it back to needs_review.

comment:17 Changed 3 years ago by git

  • Commit changed from 0e27dc115ee56fe93e6ccd7cba50530aedca5e52 to eeacf86dc397fedbfd780aa17af01a8a0a3fb28a

Branch pushed to git repo; I updated commit sha1. New commits:

996b265Merged fixes from ticket #25395 into this branch.
eeacf86Minor documentation fixes.

comment:18 Changed 3 years ago by git

  • Commit changed from eeacf86dc397fedbfd780aa17af01a8a0a3fb28a to b46f9225df60e274ac407ebf084492afa0976c86

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

0423f81Removed canonical form to fix doctest.
c7e9db8Moved an import
626d1edDocumentation fixes based on reviewers comments.
13202e5Minor documentation fixes.
c1b7a69Documentation fixes.
2d53868Documentation fixes and bugfix with homogenisation and transvectant.
a4c7b97Documentation fix.
2ee55b5Adjustment to AlgebraicForm string representation.
0abc79dMerge branch 't/25395/binary_quintics' into t/25508/binary_quintics_reconstruction.
b46f922Doctest fix.

comment:19 Changed 3 years ago by jnoordsij

  • Dependencies changed from #25395 to #25395, #26370
  • Description modified (diff)

comment:20 Changed 3 years ago by jnoordsij

  • Branch changed from u/jnoordsij/binary_quintics_reconstruction to u/jnoordsij/binary_quintics_reconstruction_2
  • Commit changed from b46f9225df60e274ac407ebf084492afa0976c86 to 329c5e19918b13f26c106232ae99cf352bf936bc

New commits:

b39f291Added reconstruction to invariant_theory.
329c5e1Merge branch 'develop' into binary_quintics_reconstruction

comment:21 Changed 3 years ago by git

  • Commit changed from 329c5e19918b13f26c106232ae99cf352bf936bc to cb6c493a53df29ef3a87662ce9a5645741a90a29

Branch pushed to git repo; I updated commit sha1. New commits:

cb6c493Added canonical_form to binary quintics in invariant_theory.

comment:22 Changed 3 years ago by jnoordsij

  • Milestone changed from sage-8.3 to sage-8.5
  • Status changed from needs_work to needs_review

comment:23 Changed 3 years ago by mstreng

  • Status changed from needs_review to needs_work

comments delivered to author personally

comment:24 Changed 3 years ago by git

  • Commit changed from cb6c493a53df29ef3a87662ce9a5645741a90a29 to e9923309801021578298bcbebb20443449fff373

Branch pushed to git repo; I updated commit sha1. New commits:

e992330Fixes based on reviewers comments.

comment:25 Changed 3 years ago by jnoordsij

  • Description modified (diff)

comment:26 Changed 3 years ago by git

  • Commit changed from e9923309801021578298bcbebb20443449fff373 to 72641a2b40524c753524cda0294406a9cc17e8a8

Branch pushed to git repo; I updated commit sha1. New commits:

72641a2Minor documentation fixes.

comment:27 Changed 3 years ago by jnoordsij

  • Status changed from needs_work to needs_review

comment:28 Changed 3 years ago by git

  • Commit changed from 72641a2b40524c753524cda0294406a9cc17e8a8 to a7eca7a1d19470b18093f9197e6a7aaf049af9fa

Branch pushed to git repo; I updated commit sha1. New commits:

a7eca7aText fix.

comment:29 Changed 3 years ago by git

  • Commit changed from a7eca7a1d19470b18093f9197e6a7aaf049af9fa to 25b8f832f5e0742c28a734ed280329f25dee09bb

Branch pushed to git repo; I updated commit sha1. New commits:

0ff4449Merge branch 'develop' into t/25508/binary_quintics_reconstruction_2
25b8f83Adjusted some formatting

comment:30 Changed 3 years ago by git

  • Commit changed from 25b8f832f5e0742c28a734ed280329f25dee09bb to c00015992e794bb9ade8e295f119de26c8ea26da

Branch pushed to git repo; I updated commit sha1. New commits:

c000159Doctest fixes

comment:31 Changed 3 years ago by git

  • Commit changed from c00015992e794bb9ade8e295f119de26c8ea26da to 0519059e58e713bb3c86fd7956932fb874328473

Branch pushed to git repo; I updated commit sha1. New commits:

5a9aadbReconstruction moved to invariant_theory factory object
0519059Documentation fixes

comment:32 Changed 2 years ago by chapoton

Please fix the patchbot warnings (pyflakes and pycodestyle plugins)

comment:33 Changed 2 years ago by chapoton

  • Dependencies #25395, #26370 deleted
  • Milestone changed from sage-8.5 to sage-8.8
  • Status changed from needs_review to needs_work

comment:34 Changed 2 years ago by git

  • Commit changed from 0519059e58e713bb3c86fd7956932fb874328473 to 9007e54aa04dc5280c6166b284a6baf4c0dcf053

Branch pushed to git repo; I updated commit sha1. New commits:

9007e54Doctest fixes

comment:35 Changed 2 years ago by chapoton

in python3:

AttributeError: 'dict' object has no attribute 'has_key'

You need to replace d.has_key(y) by y in d

comment:36 Changed 2 years ago by chapoton

typo "given variants"

comment:37 Changed 2 years ago by embray

  • Milestone changed from sage-8.8 to sage-8.9

Tickets still needing working or clarification should be moved to the next release milestone at the soonest (please feel free to revert if you think the ticket is close to being resolved).

comment:38 Changed 2 years ago by git

  • Commit changed from 9007e54aa04dc5280c6166b284a6baf4c0dcf053 to e51413855314a289154d91f89aac253bd3371da5

Branch pushed to git repo; I updated commit sha1. New commits:

e514138Python 3 fix and typo fix

comment:39 Changed 2 years ago by chapoton

back to needs review ?

comment:40 Changed 2 years ago by chapoton

  • Status changed from needs_work to needs_review

ok, I will assume so.. but you should rather react yourself..

comment:41 Changed 2 years ago by jnoordsij

  • Status changed from needs_review to needs_work

I will implement a more general binary_form_from_invariants method, with an additional binary_quintic_coefficients_from_invariants method.

comment:42 Changed 2 years ago by git

  • Commit changed from e51413855314a289154d91f89aac253bd3371da5 to 56a0d79a27301f5baf009e80d0165ea605e49f2f

Branch pushed to git repo; I updated commit sha1. New commits:

c713632Adjust coefficients scaling
56a0d79Adjust reconstruction methods so Form objects are returned by default

comment:43 Changed 2 years ago by chapoton

needs review ?

comment:44 Changed 2 years ago by jnoordsij

I intend to do a last check if there are sufficient doctests and references later this week; after that I will change to needs review again.

comment:45 Changed 2 years ago by jnoordsij

  • Status changed from needs_work to needs_review

comment:46 Changed 2 years ago by git

  • Commit changed from 56a0d79a27301f5baf009e80d0165ea605e49f2f to 383cd481005ec259ac0e65277c85692970ef7dd8

Branch pushed to git repo; I updated commit sha1. New commits:

383cd48Update doctests and documentation of several methods

comment:47 Changed 2 years ago by chapoton

looks almost good.

Error messages should not end with a dot and should not start with a capital. They should look something like

IncredibleError: this banana is blue

comment:48 Changed 2 years ago by git

  • Commit changed from 383cd481005ec259ac0e65277c85692970ef7dd8 to ff11a5dbf81e097b37a8821f853ca73e02ae373c

Branch pushed to git repo; I updated commit sha1. New commits:

ff11a5dUpdate format of error messages

comment:49 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be.

comment:50 Changed 2 years ago by chapoton

  • Milestone changed from sage-8.9 to sage-9.0

comment:51 Changed 2 years ago by vbraun

  • Branch changed from u/jnoordsij/binary_quintics_reconstruction_2 to ff11a5dbf81e097b37a8821f853ca73e02ae373c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.