Opened 3 years ago
Closed 3 years ago
#25504 closed defect (fixed)
Implement _an_element_ for matrix spaces
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage8.3 
Component:  linear algebra  Keywords:  
Cc:  vdelecroix  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  779dffb (Commits, GitHub, GitLab)  Commit:  779dffbbb514290400d2b164b80ddb1a6c8ba04e 
Dependencies:  Stopgaps: 
Description
Currently, this is a bit too trivial:
sage: MatrixSpace(QQ, 3, 3).an_element() [1 0 0] [0 0 0] [0 0 0]
Change History (12)
comment:1 Changed 3 years ago by
 Branch set to u/jdemeyer/implement__an_element__for_matrix_spaces
comment:2 Changed 3 years ago by
 Commit set to ac7cf066bd3dfffb0cc5292f55ce5d9d36094a0a
comment:3 Changed 3 years ago by
 Status changed from new to needs_review
comment:5 Changed 3 years ago by
 Commit changed from ac7cf066bd3dfffb0cc5292f55ce5d9d36094a0a to 2c09211e782ea84946e25636c3ae25049ca50425
Branch pushed to git repo; I updated commit sha1. New commits:
2c09211  Doctest fixes

comment:6 Changed 3 years ago by
 Status changed from needs_work to needs_review
comment:7 Changed 3 years ago by
If you could add a test M.density()
for the sparse test to verify that it is indeed sparse (beyond the implicit test that you would kill your memory if such a sparse matrix was dense). Actually, that test makes me a bit nervous if at some point it does turn into a dense matrix. It would make it nearly impossible to debug because my computer would keep running out of memory. Perhaps it would be better to scale down the matrix and just do M.density()
to show it is sparse.
comment:8 Changed 3 years ago by
 Commit changed from 2c09211e782ea84946e25636c3ae25049ca50425 to e09aed6e246816e232680ceba22096a756cf9ba8
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
e09aed6  Implement _an_element_ for matrix spaces

comment:9 Changed 3 years ago by
I updated the branch.
comment:10 Changed 3 years ago by
 Commit changed from e09aed6e246816e232680ceba22096a756cf9ba8 to 779dffbbb514290400d2b164b80ddb1a6c8ba04e
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
779dffb  Implement _an_element_ for matrix spaces

comment:11 Changed 3 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
Thank you. LGTM.
comment:12 Changed 3 years ago by
 Branch changed from u/jdemeyer/implement__an_element__for_matrix_spaces to 779dffbbb514290400d2b164b80ddb1a6c8ba04e
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
Implement _an_element_ for matrix spaces