Opened 3 years ago

Closed 3 years ago

#25487 closed defect (fixed)

bug in the minimal (non-)working example of a finite coxeter group

Reported by: stumpc5 Owned by:
Priority: major Milestone: sage-8.3
Component: combinatorics Keywords: cartan matrix, days93.51
Cc: sage-combinat, nthiery, tscrim Merged in:
Authors: Christian Stump Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c954af8 (Commits, GitHub, GitLab) Commit: c954af81710070abde60f805aa91654493859ca9
Dependencies: Stopgaps:

Status badges

Description


Change History (7)

comment:1 Changed 3 years ago by stumpc5

  • Branch set to u/stumpc5/bug_in_the_minimal__non__working_example_of_a_finite_coxeter_group

comment:2 Changed 3 years ago by git

  • Commit set to 53aa3aba02823b3574a5f4f53329a83bdcdc4fb3

Branch pushed to git repo; I updated commit sha1. New commits:

53aa3abrelabel the cartan type

comment:3 Changed 3 years ago by stumpc5

  • Authors set to Christian Stump
  • Cc tscrim added
  • Component changed from PLEASE CHANGE to combinatorics
  • Keywords cartan matrix days93.51 added
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

comment:4 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to needs_work

It needs a docstring/test.

comment:5 Changed 3 years ago by tscrim

  • Branch changed from u/stumpc5/bug_in_the_minimal__non__working_example_of_a_finite_coxeter_group to public/combinat/bug_finite_weyl_group_example-25487
  • Cc sage-combinat nthiery added
  • Commit changed from 53aa3aba02823b3574a5f4f53329a83bdcdc4fb3 to c954af81710070abde60f805aa91654493859ca9
  • Status changed from needs_work to needs_review

New commits:

c954af8Adding some documentation.

comment:6 Changed 3 years ago by stumpc5

  • Status changed from needs_review to positive_review

lgtm

comment:7 Changed 3 years ago by vbraun

  • Branch changed from public/combinat/bug_finite_weyl_group_example-25487 to c954af81710070abde60f805aa91654493859ca9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.