Opened 3 years ago

Closed 3 years ago

#25479 closed enhancement (fixed)

Add jacobian of fundamental invariants

Reported by: stumpc5 Owned by:
Priority: major Milestone: sage-8.3
Component: combinatorics Keywords: complex reflection groups, days93.51
Cc: tscrim, jmichel, tdouvropoulos Merged in:
Authors: Christian Stump Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 688686a (Commits, GitHub, GitLab) Commit: 688686a68fe29a8a2d6be7027e4027fde2c0edfd
Dependencies: #25467 Stopgaps:

Status badges

Description (last modified by stumpc5)

Implement the jacobian of the fundamental invariants in a reflection group and also the primitive vector field given by the derivation along the unique hightest invariant.

Change History (10)

comment:1 Changed 3 years ago by stumpc5

  • Branch set to u/stumpc5/add_jacobian_of_fundamental_invariants

comment:2 Changed 3 years ago by stumpc5

  • Authors set to Christian Stump
  • Cc tscrim jmichel tdouvropoulos added
  • Commit set to 06c23ab6889bb79fe87129b2a7f40b27dc463643
  • Component changed from PLEASE CHANGE to combinatorics
  • Description modified (diff)
  • Keywords complex reflection groups days93.51 added
  • Type changed from PLEASE CHANGE to enhancement

New commits:

56a8fe3jacobian and primitive vector field for reflection groups
d622df2started the discriminant of a reflection group
3d4f036implemented the discriminant up- and downstairs
294e728added doctests for power
3e2059dadded doctests for hyperplane linear functionals
25f078cSome reviewer changes.
4aabb8aMerge branch 't/25467/add_liner_forms_for_reflecting_hyperplanes_in_reflection_group' into t/25479/add_jacobian_of_fundamental_invariants
06c23abmoved stuff around

comment:3 Changed 3 years ago by git

  • Commit changed from 06c23ab6889bb79fe87129b2a7f40b27dc463643 to 3c013eca6a24b2baa94467af24e816caeb8ad5db

Branch pushed to git repo; I updated commit sha1. New commits:

3c013ecadded some error messages

comment:4 Changed 3 years ago by stumpc5

  • Status changed from new to needs_review

comment:5 Changed 3 years ago by git

  • Commit changed from 3c013eca6a24b2baa94467af24e816caeb8ad5db to b1ed2f02fe0b3646f42d028c19d6b5d3ae00e401

Branch pushed to git repo; I updated commit sha1. New commits:

941e3e3added doctest for jacobian
406b7b1added doctests for the primitive vector field
b1ed2f0fixed doctests

comment:6 Changed 3 years ago by tscrim

  • Branch changed from u/stumpc5/add_jacobian_of_fundamental_invariants to public/combinat/jacobian_fundamental_invariants-25479
  • Commit changed from b1ed2f02fe0b3646f42d028c19d6b5d3ae00e401 to 28ad7a661420ee4d988d1c94c4609cf16a3f8413
  • Dependencies set to #25467
  • Reviewers set to Travis Scrimshaw

If my changes are good then positive review.


New commits:

3f2667eTrivial fixing of docstring.
50b4f1cMerge branch 'public/combinat/discriminant_reflection_groups-25467' into public/combinat/jacobian_fundamental_invariants-25479
28ad7a6Some reviewer tweaks to the doc and removing duplicates.

comment:7 Changed 3 years ago by stumpc5

  • Status changed from needs_review to positive_review

comment:8 Changed 3 years ago by git

  • Commit changed from 28ad7a661420ee4d988d1c94c4609cf16a3f8413 to 688686a68fe29a8a2d6be7027e4027fde2c0edfd
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

688686aMarking tests as gap3.

comment:9 Changed 3 years ago by tscrim

  • Status changed from needs_review to positive_review

Marking some tests gap3.

comment:10 Changed 3 years ago by vbraun

  • Branch changed from public/combinat/jacobian_fundamental_invariants-25479 to 688686a68fe29a8a2d6be7027e4027fde2c0edfd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.