Opened 18 months ago

Closed 18 months ago

#25478 closed defect (fixed)

Fix bug in is_regular

Reported by: tdouvropoulos Owned by:
Priority: major Milestone: sage-8.3
Component: combinatorics Keywords: reflection groups, days93.51
Cc: tscrim, stumpc5 Merged in:
Authors: Theo Douvropoulos Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: e0a1db4 (Commits) Commit: e0a1db494a16371a37877b7d6b1c4de0b8ecbcaf
Dependencies: Stopgaps:

Description

The function is_regular for elements of complex reflection groups has a bug.

For example, the following code gives: 

sage: W=ReflectionGroup(["A",5])
sage: w=W.from_reduced_word([1,2,3,5])
sage: w.is_regular(4)
True

The element w above is (1234)(56), and is not regular. Its order isn't even a regular number.

Change History (18)

comment:1 Changed 18 months ago by tdouvropoulos

  • Authors changed from tdouvropoulos to Theo Douvropoulos
  • Branch set to public/combinat/fix_is_regular
  • Commit set to a13f83929ab2337e59f7074d2d87535b3f0a83e7
  • Reviewers set to Travis Scrimshaw
  • Status changed from new to needs_review

New commits:

​a13f839Fixing is_regular for complex reflection groups.

comment:2 Changed 18 months ago by git

  • Commit changed from a13f83929ab2337e59f7074d2d87535b3f0a83e7 to 1677bfc1d580bcca4b7b315c92e04b99a6668a10

Branch pushed to git repo; I updated commit sha1. New commits:

​1677bfcAdded test documentation in is_regular

comment:3 Changed 18 months ago by git

  • Commit changed from 1677bfc1d580bcca4b7b315c92e04b99a6668a10 to e104f570b181931d289d2277651c6401063ffcfa

Branch pushed to git repo; I updated commit sha1. New commits:

​e104f57Fixed examples.

comment:4 Changed 18 months ago by git

  • Commit changed from e104f570b181931d289d2277651c6401063ffcfa to 4f119e4841e8269572d08393ab990f7fe83b23a2

Branch pushed to git repo; I updated commit sha1. New commits:

​4f119e4Improved code

comment:5 Changed 18 months ago by git

  • Commit changed from 4f119e4841e8269572d08393ab990f7fe83b23a2 to b25ec8f7935049d517d9e0e137b4c0125859dba1

Branch pushed to git repo; I updated commit sha1. New commits:

​b25ec8fSome changes and simplifications to the code.

comment:6 Changed 18 months ago by git

  • Commit changed from b25ec8f7935049d517d9e0e137b4c0125859dba1 to c70c41c68fe279cb5d37aa47098f101aa95696aa

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​c70c41cSome changes and simplifications to the code.

comment:7 Changed 18 months ago by tscrim

  • Keywords changed from reflection groups,days 93.51 to reflection groups, days 93.51

If my changes look good, then positive review.

comment:8 Changed 18 months ago by git

  • Commit changed from c70c41c68fe279cb5d37aa47098f101aa95696aa to ab41798f674ef9a81fa83a6c92ecc8044d4d2752

Branch pushed to git repo; I updated commit sha1. New commits:

​ab41798Fixed bug in code

comment:9 Changed 18 months ago by tdouvropoulos

The base change to the Universal cyclotomic field needs to happen every time including the crystallographic groups. The eigenvectors of elements in crystallographic groups are not always defined over Q.

comment:10 Changed 18 months ago by stumpc5

oh yes...

comment:11 Changed 18 months ago by git

  • Commit changed from ab41798f674ef9a81fa83a6c92ecc8044d4d2752 to cdf429de05279336b9a60bfa4cad7fc7486b684f

Branch pushed to git repo; I updated commit sha1. New commits:

​cdf429dSimplified code

comment:12 Changed 18 months ago by tscrim

  • Keywords days93.51 added; days 93.51 removed

comment:13 Changed 18 months ago by git

  • Commit changed from cdf429de05279336b9a60bfa4cad7fc7486b684f to 426248ca36c975a738d342f740313b321b55239d

Branch pushed to git repo; I updated commit sha1. New commits:

​596b2f7Implement fake degree polynomials from Chevie.
​dd7c992Improved code and description
​16f6c87Reviewer changes for fake_degrees.
​531cc09Adding Malle's Coxeter numbers
​627c973Small modifications
​b49d8b7Reviewer changes.
​4ac2edaMerge branch 'public/combinat/Malle-Coxeter-number' into public/combinat/fake_degree_polys
​10b07baMerge branch 'public/combinat/fix_is_regular' of trac.sagemath.org:sage into public/combinat/fix_is_regular
​426248cSome last little changes.

comment:14 Changed 18 months ago by git

  • Commit changed from 426248ca36c975a738d342f740313b321b55239d to 582e7b043be1614e3134d94e436121a66ead164b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​582e7b0Some last little changes.

comment:15 Changed 18 months ago by tdouvropoulos

  • Status changed from needs_review to positive_review

comment:16 Changed 18 months ago by git

  • Commit changed from 582e7b043be1614e3134d94e436121a66ead164b to e0a1db494a16371a37877b7d6b1c4de0b8ecbcaf
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​e0a1db4Fixed minor typo

comment:17 Changed 18 months ago by tscrim

  • Status changed from needs_review to positive_review

comment:18 Changed 18 months ago by vbraun

  • Branch changed from public/combinat/fix_is_regular to e0a1db494a16371a37877b7d6b1c4de0b8ecbcaf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.