Opened 4 years ago
Closed 4 years ago
#25471 closed defect (fixed)
OEIS update (database format change, new entries, incorrect warning handling)
Reported by: | slabbe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.3 |
Component: | combinatorics | Keywords: | days94 |
Cc: | Merged in: | ||
Authors: | Thierry Monteil | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | 9889222 (Commits, GitHub, GitLab) | Commit: | 9889222e7915e75d3a0ebe4a6e156e3b8e207087 |
Dependencies: | Stopgaps: |
Description (last modified by )
This ticket fixes the 34 doctest failures that happen when internet is enabled, see this sage-release thread.
There are 3 kinds or errors:
- the oeis database gets updated with new data (this is a normal update),
- the oeis database changed its internal format, and does not make difference between signed and unsigned sequences anymore (in particular, for signed sequences, the
V,W,X
fields disapear, and are replaced with theS,T,U
fields), - the warnings triggered when a dead sequence is met were not correctly doctested.
The 3 commits corresponds to these 3 kind of errors
To test the branch:
sage -t --optional=sage,internet src/sage/databases/oeis.py
Change History (17)
comment:1 Changed 4 years ago by
- Summary changed from sage -t --optional=sage,internet src/sage/databases/oeis.py has 34 doctests failed to 34 doctests failed in databases/oeis.py
comment:2 Changed 4 years ago by
- Summary changed from 34 doctests failed in databases/oeis.py to 34 internet doctests failed in databases/oeis.py
comment:3 Changed 4 years ago by
- Description modified (diff)
comment:4 Changed 4 years ago by
- Description modified (diff)
comment:5 Changed 4 years ago by
- Description modified (diff)
comment:6 Changed 4 years ago by
Hi,
i will be on this (some might be tricky, e.g. related to dead sequences).
You write:
Note that, as Sloane writes this week on the arxiv, the oeis is a now a Wiki which means that Sage doctests should depend as few as possible on the many modifications done on the OEIS database...
Are you suggesting to parse the wiki ???
Note that the issue of the database changing was discussed in previous tickets. Still, we should show part of the answers for having meaningful examples (not only for testing purpose, but also for the user).
comment:7 Changed 4 years ago by
By the way, several of us predicted this sort of situation (lots of broken doctests related to OEIS) in #16252.
comment:8 Changed 4 years ago by
- Keywords days94 added
comment:9 Changed 4 years ago by
- Branch set to u/tmonteil/34_internet_doctests_failed_in_databases_oeis_py
comment:10 Changed 4 years ago by
- Branch u/tmonteil/34_internet_doctests_failed_in_databases_oeis_py deleted
comment:11 Changed 4 years ago by
- Branch set to u/tmonteil/oeis_update
comment:12 Changed 4 years ago by
- Commit set to cf7a0aa9e1627db79a332def992da45fab7a5f0d
Branch pushed to git repo; I updated commit sha1. New commits:
cf7a0aa | merge
|
comment:13 Changed 4 years ago by
- Branch u/tmonteil/oeis_update deleted
- Commit cf7a0aa9e1627db79a332def992da45fab7a5f0d deleted
comment:14 Changed 4 years ago by
- Branch set to u/tmonteil/oeis_update
comment:15 Changed 4 years ago by
- Commit set to 9889222e7915e75d3a0ebe4a6e156e3b8e207087
- Description modified (diff)
- Status changed from new to needs_review
- Summary changed from 34 internet doctests failed in databases/oeis.py to OEIS update (database format change, new entries, incorrect warning handling)
comment:16 Changed 4 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
ok (but this will need to be done again and again...)
comment:17 Changed 4 years ago by
- Branch changed from u/tmonteil/oeis_update to 9889222e7915e75d3a0ebe4a6e156e3b8e207087
- Resolution set to fixed
- Status changed from positive_review to closed
shorter title