Opened 3 years ago
Closed 3 years ago
#25466 closed enhancement (fixed)
Ambient space transformation for reflection groups
Reported by: | stumpc5 | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.3 |
Component: | combinatorics | Keywords: | matrix root, days93.51, reflection group |
Cc: | jmichel, tscrim | Merged in: | |
Authors: | Christian Stump | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | ae97b08 (Commits, GitHub, GitLab) | Commit: | ae97b08af244135ccf36ee73441b371f83bc240a |
Dependencies: | #25464 | Stopgaps: |
Description
Change History (8)
comment:1 Changed 3 years ago by
- Branch set to u/stumpc5/ambient_space_transformation_for_reflection_groups
comment:2 Changed 3 years ago by
- Cc jmichel tscrim added
- Commit set to adadb1490c05cb728c083217c65279a6cd23af61
- Component changed from PLEASE CHANGE to combinatorics
- Keywords matrix root days93.51 reflection group added
- Status changed from new to needs_review
- Type changed from PLEASE CHANGE to enhancement
comment:3 Changed 3 years ago by
- Dependencies set to #25464
comment:4 Changed 3 years ago by
- Branch changed from u/stumpc5/ambient_space_transformation_for_reflection_groups to public/combinat/ambient_space_reflection_groups-25466
- Commit changed from adadb1490c05cb728c083217c65279a6cd23af61 to 093509b0c997ca14b41c2e6e14a4878fb5bd4e30
- Reviewers set to Travis Scrimshaw
New commits:
093509b | Adding doctest and adding some examples.
|
comment:5 Changed 3 years ago by
- Commit changed from 093509b0c997ca14b41c2e6e14a4878fb5bd4e30 to 94e115dc3e7a258c7876fdd71e93c617b3466b46
Branch pushed to git repo; I updated commit sha1. New commits:
94e115d | make invariant form to belong to smaller ring if possible
|
comment:6 Changed 3 years ago by
- Commit changed from 94e115dc3e7a258c7876fdd71e93c617b3466b46 to ae97b08af244135ccf36ee73441b371f83bc240a
Branch pushed to git repo; I updated commit sha1. New commits:
c5df0a9 | Some minor reviewer tweaks.
|
eaa868c | Merge branch 'public/linear_algerba/principal_sqrt_psd_matrix-25464' of trac.sagemath.org:sage into public/combinat/ambient_space_reflection_groups-25466
|
ae97b08 | Fixing some things in the docs and tests.
|
comment:7 Changed 3 years ago by
- Status changed from needs_review to positive_review
Christian reviewed my changes over my shoulder.
comment:8 Changed 3 years ago by
- Branch changed from public/combinat/ambient_space_reflection_groups-25466 to ae97b08af244135ccf36ee73441b371f83bc240a
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
implemented principal square root
implemented invariant_form_standardization