Changes between Initial Version and Version 1 of Ticket #25438, comment 14


Ignore:
Timestamp:
06/19/18 15:52:14 (3 years ago)
Author:
egourgoulhon
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25438, comment 14

    initial v1  
    1 In the above "reviewer tweaks", I've mostly ammended the documentation. The main change is the removal of the `@cached_method` decorator on methods like `first_fundamental_form` and the removal of the duplicated code in methods like `induced_metric`. I understand that this was performed to address the documentation issue related to `@cached_method` mentioned in comment:8. In the new setting, the caching is performed "manually", by checking whether the attribute `self._first_fundamental_form` is `None` or not, and the alias is properly defined as
     1In the above "reviewer tweaks", I've mostly amended the documentation. The main change is the removal of the `@cached_method` decorator on methods like `first_fundamental_form` and the removal of the duplicated code in methods like `induced_metric`. I understand that this was introduced to address the documentation issue related to `@cached_method` mentioned in comment:8. In the new setting, the caching is performed "manually", by checking whether the attribute `self._first_fundamental_form` is `None` or not, and the alias is properly defined as
    22{{{
    33extrinsic_curvature = second_fundamental_form
    44}}}
    5 This avoids the duplication of doctests. As a result, the doctest time for `pseudo_riemannian_submanifold.py` decreases from 315 s to 248 s (on my computer). However this is still too much! A solution would be to replace most (all?) the sphere examples by simpler ones, like those for a cylinder, or even by those for a plane, in cases where they are not trivial (e.g. for the normal).
     5This avoids the duplication of doctests. As a result, the doctest time for the file `pseudo_riemannian_submanifold.py` decreases from 315 s to 248 s (on my computer). However this is still too much! A solution would be to replace most (all?) the sphere examples by simpler ones, like those for a cylinder, or even by those for a plane, in cases where they are not trivial (e.g. for the normal).
    66
    77Another thing to do is to distinguish which methods are valid for a generic submanifold, like `first_fundamental_form` or `projector`, and those that are valid only for hypersurfaces, like `second_fundamental_form` or `normal`.
    88
    9 I am leaving the ticket status to "needs review" to catch the attention of the patchbot.
     9I am leaving the ticket status to "needs review" to catch the attention of the patchbot...