Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#25431 closed defect (fixed)

Timeouts in lattice precision

Reported by: saraedum Owned by:
Priority: critical Milestone: sage-8.3
Component: padics Keywords:
Cc: caruso, roed, chapoton Merged in:
Authors: Julian Rüth, Xavier Caruso Reviewers: Julian Rüth, David Loeffler
Report Upstream: N/A Work issues:
Branch: b80dc9e (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by saraedum)

The patchbots time out with some lattice precision tests https://patchbot.sagemath.org/log/0/Ubuntu/18.04/x86_64/4.15.0-20-generic/petitbonum/2018-05-11%2012:03:31?short. I have also seen the same issues with GitLab? CI tests.

The test suite takes too much time, more precisely _test_matrix_smith.

sage: R = QpLC(7, label='init')
sage: %time TestSuite(R).run(skip='_test_teichmuller')
Wall time: 2min 59s
sage: %time R._test_matrix_smith()
Wall time: 2min 56s

Change History (15)

comment:1 Changed 3 months ago by saraedum

  • Cc caruso roed chapoton added

comment:2 Changed 3 months ago by saraedum

  • Authors set to Julian Rüth
  • Description modified (diff)

comment:3 Changed 3 months ago by saraedum

  • Branch set to u/saraedum/25431

comment:4 Changed 3 months ago by saraedum

  • Commit set to 16ecaab3129389cd5f2d7afb55ad949893c0f7ea
  • Status changed from new to needs_review

I have not run doctests yet, so let's see if the patchbots are happy now.


New commits:

16ecaabSkip _test_matrix_smith for lattice precision rings

comment:5 Changed 3 months ago by git

  • Commit changed from 16ecaab3129389cd5f2d7afb55ad949893c0f7ea to e67314c4adb29748b4ef683f351b1a1094c837de

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e67314cSkip _test_matrix_smith for lattice precision rings

comment:6 Changed 3 months ago by chapoton

I have launched my patchbot having the timeout issue, to see if the branch brings any progress.

comment:7 Changed 3 months ago by chapoton

This indeed seems to fix the timeout issue (see petibonum report)

Note: my patchbot has found some pyflakes errors in the modified files, see the pyflakes plugin.

comment:8 Changed 3 months ago by jdemeyer

FYI: short doctests should take at most 1 second or so and long doctests at most 30 seconds (unless for exceptional reasons).

comment:9 Changed 3 months ago by caruso

  • Branch changed from u/saraedum/25431 to u/caruso/25431

comment:10 Changed 3 months ago by caruso

  • Commit changed from e67314c4adb29748b4ef683f351b1a1094c837de to b80dc9e2d1996a76de2ef286d8860262cbfaaaa0

I fixed the pyflakes warnings.


New commits:

b80dc9eFix pyflakes errors

comment:11 Changed 3 months ago by saraedum

  • Authors changed from Julian Rüth to Julian Rüth, Xavier Caruso

comment:12 Changed 3 months ago by saraedum

  • Reviewers set to Julian Rüth

Xavier, your changes look good. Can you review my original changes?

comment:13 Changed 3 months ago by davidloeffler

  • Reviewers changed from Julian Rüth to Julian Rüth, David Loeffler
  • Status changed from needs_review to positive_review

Changes look reasonable + it gets the timings down to an acceptable level. Positive review.

comment:14 Changed 3 months ago by vbraun

  • Branch changed from u/caruso/25431 to b80dc9e2d1996a76de2ef286d8860262cbfaaaa0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:15 Changed 3 months ago by embray

  • Commit b80dc9e2d1996a76de2ef286d8860262cbfaaaa0 deleted

As noted on the mailing list, I am also getting

sage -t src/sage/rings/padics/padic_base_leaves.py
    Timed out (with segmentation fault after interrupt)

on cygwin. I will test this patch and see if the tests at least pass with these tests skipped by default (and I will also test with --long)

Note: See TracTickets for help on using tickets.