Opened 5 years ago

Closed 5 years ago

#25398 closed defect (fixed)

Feature doctest for plantri broken

Reported by: Vincent Delecroix Owned by:
Priority: blocker Milestone: sage-8.3
Component: documentation Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: da8900d (Commits, GitHub, GitLab) Commit: da8900dea3836531bf51fc599e1a796b731cb277
Dependencies: Stopgaps:

Status badges

Description

The fix in #25333 did not care about doctests

sage -t --long src/sage/features/graph_generators.py
**********************************************************************
File "src/sage/features/graph_generators.py", line 20, in sage.features.graph_generators.Plantr
i
Failed example:
    Plantri().is_present()  # optional: plantri
Expected:
    FeatureTestResult('plantri', False)
Got:
    FeatureTestResult('plantri', True)
**********************************************************************
File "src/sage/features/graph_generators.py", line 40, in sage.features.graph_generators.Plantri.is_functional
Failed example:
    Plantri().is_functional()  # optional: plantri
Expected:
    FeatureTestResult('plantri', False)
Got:
    FeatureTestResult('plantri', True)
**********************************************************************
2 items had failures:
   1 of   3 in sage.features.graph_generators.Plantri
   1 of   3 in sage.features.graph_generators.Plantri.is_functional

Change History (3)

comment:1 Changed 5 years ago by Frédéric Chapoton

Authors: Frédéric Chapoton
Branch: public/25398
Commit: da8900dea3836531bf51fc599e1a796b731cb277
Status: newneeds_review

done


New commits:

da8900dfixing doctests for feature / plantri

comment:2 Changed 5 years ago by Vincent Delecroix

Reviewers: Vincent Delecroix
Status: needs_reviewpositive_review

Thanks!

comment:3 Changed 5 years ago by Volker Braun

Branch: public/25398da8900dea3836531bf51fc599e1a796b731cb277
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.