Changes between Version 5 and Version 10 of Ticket #25393


Ignore:
Timestamp:
05/21/18 16:51:57 (3 years ago)
Author:
embray
Comment:

New commits:

1a99057remove unused and potentially misleading __hash__ implementation for Morphisms

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25393

    • Property Status changed from needs_info to needs_review
    • Property Authors changed from to Erik Bray
    • Property Summary changed from Fix hash for ContinuousMap to Removed unused and potentially misleading Morphism.__hash__
    • Property Branch changed from to u/embray/misc/ticket-25393
    • Property Commit changed from to 1a990578b1b8f0826fa0408aaac424b205f5dffb
  • Ticket #25393 – Description

    v5 v10  
     1As far as I can tell there is no code using the ability to hash `Morphisms`, and having this in the base class is misleading since there are subclasses which are not immutable and should not be hashable anyways.  It would be better to implement `__hash__` on an as-needed basis for those classes that can guarantee immutability.
     2
     3=== Original description ===
    14`ContinuousMap` is impacted by #24551 in that it defines an `__eq__`, so its default hash is not inherited from its base class, `Morphism` (which does define `__hash__`).
    25