Opened 4 years ago
Last modified 8 weeks ago
#25389 needs_work enhancement
Clean up UniqueRepresentations in sage.algebra (part 2)
Reported by: | embray | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.7 |
Component: | algebra | Keywords: | |
Cc: | Merged in: | ||
Authors: | Erik Bray | Reviewers: | Nils Bruin |
Report Upstream: | N/A | Work issues: | |
Branch: | u/embray/misc/unique-repr/algebras-2 (Commits, GitHub, GitLab) | Commit: | 9ea55d9933a3cd2bedd391068276f804ff868e1f |
Dependencies: | #25388 | Stopgaps: |
Description
This is like #25387 but adds UniqueRepresentation
to classes that weren't using it (specifically in sage.algebras.quatalg
) but looked like they could benefit.
Change History (15)
comment:1 Changed 4 years ago by
- Status changed from new to needs_review
comment:2 Changed 4 years ago by
- Reviewers set to Nils Bruin
- Status changed from needs_review to needs_work
comment:3 Changed 4 years ago by
#25672 goes ahead and implements a __hash__
for quaternion algebras. I believe this should ultimately be removed as in this ticket (alone with the __eq__
), but first we need the hypothetical class I mention above.
comment:4 Changed 4 years ago by
- Milestone changed from sage-8.3 to sage-8.4
I believe this issue can reasonably be addressed for Sage 8.4.
comment:5 Changed 4 years ago by
- Milestone changed from sage-8.4 to sage-8.5
comment:6 Changed 3 years ago by
- Milestone changed from sage-8.5 to sage-8.7
Retargeting some of my tickets (somewhat optimistically for now).
comment:7 Changed 3 years ago by
- Milestone changed from sage-8.7 to sage-8.8
Moving all my in-progress tickets to 8.8 milestone.
comment:8 Changed 3 years ago by
- Milestone changed from sage-8.8 to sage-8.9
Tickets still needing working or clarification should be moved to the next release milestone at the soonest (please feel free to revert if you think the ticket is close to being resolved).
comment:9 Changed 2 years ago by
- Milestone changed from sage-8.9 to sage-9.1
Ticket retargeted after milestone closed
comment:10 Changed 2 years ago by
- Milestone changed from sage-9.1 to sage-9.2
Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.
comment:11 Changed 21 months ago by
- Milestone changed from sage-9.2 to sage-9.3
comment:12 Changed 16 months ago by
- Milestone changed from sage-9.3 to sage-9.4
Setting new milestone based on a cursory review of ticket status, priority, and last modification date.
comment:13 Changed 10 months ago by
- Milestone changed from sage-9.4 to sage-9.5
Setting a new milestone for this ticket based on a cursory review.
comment:14 Changed 5 months ago by
- Milestone changed from sage-9.5 to sage-9.6
comment:15 Changed 8 weeks ago by
- Milestone changed from sage-9.6 to sage-9.7
Per nbruin's comments on #25388, it doesn't really make sense and/or is overkill to use
UniqueRepresentation
for quaternion algebras, and what I really want here is some hypothetical mix-in class that provides equality and hashing by some specific set of attributes of each instance--typically attributes whose values are provided to the__init__
(so long as they are hashable).